From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] pygrub: always append --args
Date: Fri, 7 Sep 2012 11:14:28 +0200
Message-ID: <20120907091428.GA12925@aepfle.de>
References: <8a2eef481d3ab3ca5692.1346945346@probook.site>
	<1347006747.30018.37.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <1347006747.30018.37.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Fri, Sep 07, Ian Campbell wrote:

> >      except IndexError:
> >          img = g.cf.images[0]
> >  
> > -    grubcfg = { "kernel": None, "ramdisk": None, "args": None }
> > +    grubcfg = { "kernel": None, "ramdisk": None, "args": "" }
> >  
> >      grubcfg["kernel"] = img.kernel[1]
> >      if img.initrd:
> >          grubcfg["ramdisk"] = img.initrd[1]
> >      if img.args:
> 
> With the above change isn't this always true?

img.args comes from img = g.cf.images[sel]?

Olaf