From: Tony Lindgren <tony@atomide.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/2] pinctrl: pinctrl-single: Make sure we do not change bits outside of mask
Date: Fri, 7 Sep 2012 14:39:22 -0700 [thread overview]
Message-ID: <20120907213922.GN1303@atomide.com> (raw)
In-Reply-To: <CACRpkdY8PLQxP85hBo4-s8hYGxQH_hKD_YwzBc6m4gnkGBknmQ@mail.gmail.com>
* Linus Walleij <linus.walleij@linaro.org> [120907 14:13]:
> On Thu, Sep 6, 2012 at 8:59 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * Peter Ujfalusi <peter.ujfalusi@ti.com> [120905 02:02]:
> >> Use the pcs->fmask to make sure that the value is not changing (setting)
> >> bits in areas where it should not.
> >> To avoid situations like this:
> >>
> >> pmx_dummy: pinmux@4a100040 {
> >> compatible = "pinctrl-single";
> >> reg = <0x4a100040 0x0196>;
> >> #address-cells = <1>;
> >> #size-cells = <0>;
> >> pinctrl-single,register-width = <16>;
> >> pinctrl-single,function-mask = <0x00ff>;
> >> };
> >>
> >> &pmx_dummy {
> >> pinctrl-names = "default";
> >> pinctrl-0 = <&board_pins>;
> >>
> >> board_pins: pinmux_board_pins {
> >> pinctrl-single,pins = <
> >> 0x6c 0xf0f
> >> 0x6e 0x10f
> >> 0x70 0x23f
> >> 0x72 0xa5f
> >> >;
> >> };
> >> };
> >>
> >> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> >
> > Thanks this is a valid fix:
> >
> > Acked-by: Tony Lindgren <tony@atomide.com>
>
> Since nothing in v3.6 is using pinctrl-simple yet, it's not a regression
> right?
Right.
> So can you just group this with the other pinctrl things you are
> harvesting in the OMAP tree? I was going to push it for
> the v3.7 cycle otherwise.
You can take this for v3.7, the changes I have are just adding .dts
entries to use the driver. The driver related changes are being
merged by the related driver lists.
Regards,
Tony
next prev parent reply other threads:[~2012-09-07 21:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 9:01 [PATCH 0/2] pinctrl: pinctrl-single: new type: pinctrl-single,bits Peter Ujfalusi
2012-09-05 9:01 ` [PATCH 1/2] pinctrl: pinctrl-single: Make sure we do not change bits outside of mask Peter Ujfalusi
2012-09-06 18:59 ` Tony Lindgren
2012-09-07 21:13 ` Linus Walleij
2012-09-07 21:39 ` Tony Lindgren [this message]
2012-09-10 7:09 ` Linus Walleij
2012-09-05 9:01 ` [PATCH 2/2] pinctrl: pinctrl-single: Add pinctrl-single,bits type of mux Peter Ujfalusi
2012-09-06 19:10 ` Tony Lindgren
2012-09-07 15:13 ` Peter Ujfalusi
2012-09-07 16:55 ` Tony Lindgren
2012-09-10 11:55 ` Peter Ujfalusi
2012-09-10 11:55 ` Peter Ujfalusi
2012-09-10 17:10 ` Tony Lindgren
2012-09-10 7:10 ` Linus Walleij
2012-09-10 18:49 ` Tony Lindgren
2012-09-05 12:10 ` [PATCH 0/2] pinctrl: pinctrl-single: new type: pinctrl-single,bits Linus Walleij
2012-09-05 18:20 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120907213922.GN1303@atomide.com \
--to=tony@atomide.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.