From: Ben Widawsky <ben@bwidawsk.net>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] intel: properly test for HAS_LLC
Date: Fri, 7 Sep 2012 23:22:19 -0700 [thread overview]
Message-ID: <20120907232219.3ff27f5f@bwidawsk.net> (raw)
In-Reply-To: <1346404733-25372-1-git-send-email-daniel.vetter@ffwll.ch>
On Fri, 31 Aug 2012 11:18:53 +0200
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> If the kernel supports the test, we need to check the param.
> Copy&pasta from the above checks that only look at the return value.
> Interesting how much one can get such a simple interface wrong.
>
> Issue created in
>
> commit 151cdcfe685ee280a4344dfc40e6087d74a5590f
> Author: Eugeni Dodonov <eugeni.dodonov@intel.com>
> Date: Tue Jan 17 15:20:19 2012 -0200
>
> intel: query for LLC support
>
> Patch even claims to have fixed this in v2, but is actually unchanged
> from v1.
>
> Reported-by: Xiang, Haihao <haihao.xiang@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
--
Ben Widawsky, Intel Open Source Technology Center
prev parent reply other threads:[~2012-09-08 6:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 9:18 [PATCH] intel: properly test for HAS_LLC Daniel Vetter
2012-09-01 7:58 ` Chris Wilson
2012-09-08 6:22 ` Ben Widawsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120907232219.3ff27f5f@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.