All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 0/1] Add lm-sensors support for it8771 (Asus E350M1-I).
Date: Sat, 08 Sep 2012 00:28:01 +0000	[thread overview]
Message-ID: <20120908002801.GA15445@roeck-us.net> (raw)
In-Reply-To: <1347060881-14106-1-git-send-email-kelly@silka.with-linux.com>

On Fri, Sep 07, 2012 at 05:34:40PM -0600, Kelly Anderson wrote:
> Signed-off-by: Kelly Anderson <kelly@silka.with-linux.com>
> 
> Kelly Anderson (1):
>   Add lm-sensors support for it8771 (Asus E350M1-I).
> 
>  drivers/hwmon/it87.c | 19 ++++++++++++++-----
>  1 file changed, 14 insertions(+), 5 deletions(-)
> 
Hi Kelly,

both in one message (Signed-off is part of the commit log), please, and

WARNING: line over 80 characters
#87: FILE: drivers/hwmon/it87.c:64:
+enum chips { it87, it8712, it8716, it8718, it8720, it8721, it8728, it8771,
it8782,

Just a note for next time - no need to resend. We'll need to sort out what
to do with the patch, ie if we want to take the risk of applying it without
technical documentation.

In this context - how does the fan output look like in your system ? Does it
make sense ? Also, can you control the fan speed with the pwm attributes,
and do the pwmX_auto_point4_XXX attributes report reasonable information ?

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2012-09-08  0:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-07 23:34 [lm-sensors] [PATCH 0/1] Add lm-sensors support for it8771 (Asus E350M1-I) Kelly Anderson
2012-09-08  0:28 ` Guenter Roeck [this message]
2012-09-08  7:21 ` Kelly Anderson
2012-09-08 14:18 ` Guenter Roeck
2012-09-08 21:11 ` Kelly Anderson
2012-09-11  3:38 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120908002801.GA15445@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.