From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TABoO-0002fY-26 for qemu-devel@nongnu.org; Fri, 07 Sep 2012 23:34:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TABoN-0000EE-2I for qemu-devel@nongnu.org; Fri, 07 Sep 2012 23:34:23 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:39331) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TABoM-0000E7-QQ for qemu-devel@nongnu.org; Fri, 07 Sep 2012 23:34:22 -0400 Received: by lbbgm13 with SMTP id gm13so193180lbb.4 for ; Fri, 07 Sep 2012 20:34:21 -0700 (PDT) Date: Sat, 8 Sep 2012 05:34:12 +0200 From: "Edgar E. Iglesias" Message-ID: <20120908033412.GB26657@zapo> References: <8f306b988fe70d9d302d87448e010c7bd0bad2bd.1346606813.git.blauwirbel@gmail.com> <20120907141841.GF6791@ohm.aurel32.net> <20120907144003.GA26657@zapo> <20120907144651.GH6791@ohm.aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120907144651.GH6791@ohm.aurel32.net> Subject: Re: [Qemu-devel] [PATCH 18/21] target-cris: switch to AREG0 free mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: Blue Swirl , qemu-devel@nongnu.org > > > case 6: > > > > > > Similarly to what I reported for the microblaze and sh4 target, I think > > > we should not start using cpu_single_env (a global variable) to replace > > > env (a global variable stored in a register). > > > > > > It is possible to pass env through the subroutine, though it is more > > > complicated there than for other targets. I have therefore done the work > > > and I have attached the two resulting patches to this mail. > > > > Hi Aurelien! > > > > I agree with your comment and change. The indentation looks a bit odd > > here though. The CRISv32 port used tabs when written but some patches > > have made it in that used space, so it's become a bit of a mess. Maybe > > it's time to convert it to the QEMU codingstyle? > > Yes, I tried to make script/checkpatch.pl happy as I know Blue Swirl > really care about that. > > > From my point of view, I think we should either keep the tabs or change > > the whole file for 4 space indent. > > > > I've got nothing against applying your patch as is and then on top of that > > the mechanical untabification, to avoid extra work on your side. > > > > As you prefer, I can also provide the same patches with tabs instead. OK, please keep your patch and when it's applied I'll put an untabification on top. Cheers, Edgar