From: Anton Vorontsov <cbouatmailru@gmail.com>
To: anish kumar <anish198519851985@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org, dwmw2@infradead.org,
linux-kernel@vger.kernel.org, lars@metafoo.de
Subject: Re: [PATCH] [RFC]power: battery: Generic battery driver using IIO
Date: Sat, 8 Sep 2012 01:34:41 -0700 [thread overview]
Message-ID: <20120908083441.GA21856@lizard> (raw)
In-Reply-To: <1347088218.5051.152.camel@anish-Inspiron-N5050>
On Sat, Sep 08, 2012 at 12:40:18PM +0530, anish kumar wrote:
[...]
> > > Signed-off-by: anish kumar <anish198519851985@gmail.com>
> > So what happened in 1985?
> Was hurrying to get an email id :)
I so much understand... ;-)
Much thanks to Lars-Peter and Jonathan, saved me a lot of time reviewing
the driver.
Anish, the idea of generic IIO driver looks great, I'm impatiently
waiting for a new revision!
One suggestion: the file name says generic-battery, the code sometimes
uses generic_adc_battery sometimes generic_battery. I'd suggest being
consistent, and stick to one naming scheme. I'd prefer
generic_adc_battery.
Thanks!
Anton.
next prev parent reply other threads:[~2012-09-08 8:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-02 15:39 [PATCH] [RFC]power: battery: Generic battery driver using IIO anish kumar
2012-09-02 16:14 ` Sannu K
2012-09-02 21:34 ` Anton Vorontsov
2012-09-04 15:05 ` anish kumar
2012-09-07 7:52 ` Jonathan Cameron
2012-09-08 7:10 ` anish kumar
2012-09-08 8:34 ` Anton Vorontsov [this message]
2012-09-08 10:09 ` Jonathan Cameron
2012-09-09 9:32 ` anish kumar
2012-09-09 9:46 ` Lars-Peter Clausen
2012-09-09 9:59 ` Jonathan Cameron
2012-09-13 15:56 ` Re:iio: Documentation change for inkern interface anish kumar
2012-09-07 8:49 ` [PATCH] [RFC]power: battery: Generic battery driver using IIO Lars-Peter Clausen
2012-09-08 7:30 ` anish kumar
2012-09-08 10:10 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2012-09-10 15:40 anish kumar
2012-09-11 9:59 ` Lars-Peter Clausen
2012-09-12 8:30 ` anish singh
2012-09-13 12:26 ` Jonathan Cameron
2012-09-13 12:33 ` anish singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120908083441.GA21856@lizard \
--to=cbouatmailru@gmail.com \
--cc=anish198519851985@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.