Re: [PATCH 07/11] defaultenv-2/ip: add dhcp-barebox support

[Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>]

On 16:04 Sat 08 Sep     , Sascha Hauer wrote:
> On Fri, Sep 07, 2012 at 02:13:33PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > ---
> >  defaultenv-2/base/bin/bootargs-ip |    2 ++
> >  defaultenv-2/base/bin/ifup        |    2 +-
> >  2 files changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/defaultenv-2/base/bin/bootargs-ip b/defaultenv-2/base/bin/bootargs-ip
> > index 2d4486c..caeb5dd 100644
> > --- a/defaultenv-2/base/bin/bootargs-ip
> > +++ b/defaultenv-2/base/bin/bootargs-ip
> > @@ -6,6 +6,8 @@
> >  
> >  if [ $ip = dhcp ]; then
> >  	global.linux.bootargs.dyn.ip="ip=dhcp"
> > +elif [ $ip = dhcp-barebox ]; then
> > +	global.linux.bootargs.dyn.ip="ip=$eth0.ipaddr:$eth0.serverip:$eth0.gateway:$eth0.netmask::eth0:"
> >  else
> >  	global.linux.bootargs.dyn.ip="ip=$ipaddr:$serverip:$gateway:$netmask::eth0:"
> >  fi
> > diff --git a/defaultenv-2/base/bin/ifup b/defaultenv-2/base/bin/ifup
> > index 37b986c..554c35e 100644
> > --- a/defaultenv-2/base/bin/ifup
> > +++ b/defaultenv-2/base/bin/ifup
> > @@ -52,7 +52,7 @@ if [ "$ip" = static ]; then
> >  	${interface}.serverip=$serverip
> >  	${interface}.gateway=$gateway
> >  	ret=0
> > -elif [ "$ip" = dhcp ]; then
> > +elif [ "$ip" = dhcp -o "$ip" = dhcp-barebox ]; then
> >  	dhcp
> >  	ret=$?
> >  	if [ $ret = 0 -a -n "$serverip" ]; then
> 
> The ifup script is used to configure networking for barebox. This is not
> the place for configuring kernel behaviour. If you want this add an
> option to the bootargs-ip script or add a bootargs-ip-barebox script.
yes but if you put dhcp-barebox mean 2 stuff you want dhcp in barebox and then
pass then to the kernel

we specify this before I wish to keep this specification

Best Regards,
J.

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox