Re: [meta-arago-distro][PATCH 1/2 v2] pinmux-utility: Add pinmux utility

[Denys Dmytriyenko <denys@ti.com>]

On Sat, Sep 08, 2012 at 04:16:42PM +0000, Cooper Jr., Franklin wrote:
> I'm unsure about this. I would think that is the point of an app or 
> library's release notes.

No, what Chase meant is for re-submition of the patches, it's common to 
explain what's different between v1 and v2 of the same patch. It's usually 
done after the --- line and before the actual diff, as that part is lost and 
won't go into the git commit description. See below...


> On Sep 8, 2012, at 10:52 AM, "Maupin, Chase" <chase.maupin@ti.com> wrote:
> 
> > Please start adding
> > 
> > ---
> > Update in version x
> >    * item 1
> >    * item 2
> > 
> > 
> > That way we know why there is a new version.
> > 
> >> -----Original Message-----
> >> From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> >> bounces@arago-project.org] On Behalf Of Franklin S. Cooper Jr
> >> Sent: Friday, September 07, 2012 2:10 PM
> >> To: meta-arago@arago-project.org
> >> Cc: Franklin S. Cooper Jr
> >> Subject: [meta-arago] [meta-arago-distro][PATCH 1/2 v2] pinmux-
> >> utility: Add pinmux utility
> >> 
> >> * Add Windows base pinmux utility
> >> * Port pinmux-utility recipe from arago.
> >> * The current recipe pulls in a zip file that doesn't contain
> >>  license information. License information will be added in an
> >>  updated recipe.
> >> 
> >> Signed-off-by: Franklin S. Cooper Jr <fcooper27jr@gmail.com>
> >> ---

Here is the proper place for any comments you don't want to go into the commit 
description, such as the reason for resubmitting the patch. Like this:

* Version 2 of the patch addresses comments about blah.


> >> .../pinmux-utility/pinmux-utility.inc              |   19
> >> +++++++++++++++
> >> .../pinmux-utility/pinmux-utility_2.3.1.0.bb       |   25
> >> ++++++++++++++++++++
> >> 2 files changed, 44 insertions(+), 0 deletions(-)
> >> create mode 100644 meta-arago-distro/recipes-arago/pinmux-
> >> utility/pinmux-utility.inc
> >> create mode 100644 meta-arago-distro/recipes-arago/pinmux-
> >> utility/pinmux-utility_2.3.1.0.bb
> >> 
> >> diff --git a/meta-arago-distro/recipes-arago/pinmux-
> >> utility/pinmux-utility.inc b/meta-arago-distro/recipes-
> >> arago/pinmux-utility/pinmux-utility.inc
> >> new file mode 100644
> >> index 0000000..46d409d
> >> --- /dev/null
> >> +++ b/meta-arago-distro/recipes-arago/pinmux-utility/pinmux-
> >> utility.inc
> >> @@ -0,0 +1,19 @@
> >> +DESCRIPTION = "Texas Instruments Pinmux Utility"
> >> +LICENSE = "BSD"
> >> +
> >> +PR = "r0"
> >> +
> >> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> >> +
> >> +S = "${WORKDIR}/${P}"
> >> +
> >> +installdir = "host-tools/pinmux_utils/windows"
> >> +
> >> +do_install() {
> >> +    install -d ${D}/${installdir}
> >> +    install ${S}/Pin_Mux_Utility.msi ${D}/${installdir}
> >> +    install ${S}/setup.exe ${D}/${installdir}
> >> +    install ${S}/Release_Notes.txt ${D}/${installdir}
> >> +}
> >> +
> >> +FILES_${PN} += "${installdir}/*"
> >> diff --git a/meta-arago-distro/recipes-arago/pinmux-
> >> utility/pinmux-utility_2.3.1.0.bb b/meta-arago-distro/recipes-
> >> arago/pinmux-utility/pinmux-utility_2.3.1.0.bb
> >> new file mode 100644
> >> index 0000000..e966f3a
> >> --- /dev/null
> >> +++ b/meta-arago-distro/recipes-arago/pinmux-utility/pinmux-
> >> utility_2.3.1.0.bb
> >> @@ -0,0 +1,25 @@
> >> +require pinmux-utility.inc
> >> +
> >> +PR_append = "-arago0"
> >> +
> >> +SRC_URI = "\
> >> +
> >> https://gforge.ti.com/gf/download/frsrelease/815/5471/PinMuxUtili
> >> ty_v2_03_01_00.zip;name=base;subdir=${P} \
> >> +"
> >> +SRC_URI[base.md5sum] = "31f28b06f72c042e5400fc53b4a29c0e"
> >> +SRC_URI[base.sha256sum] =
> >> "2b0de3592c5f4b803a207d092dba227d10e1af65e0d4f06e1d8d23f317a452f9
> >> "
> >> +
> >> +# Currently for omapl138 devices we are using a different pinmux
> >> utility
> >> +# program.  This requires a separate SRC_URI as well as a
> >> different
> >> +# do_install.
> >> +SRC_URI_omapl138 = "\
> >> +
> >> https://gforge.ti.com/gf/download/frsrelease/461/4210/Pin_Setup_A
> >> M18xx_01_00_1076_03.zip;name=omapl138;subdir=${P} \
> >> +"
> >> +
> >> +do_install_omapl138() {
> >> +    install -d ${D}/${installdir}
> >> +    cp -rf ${S}/bin ${D}/${installdir}/
> >> +    cp -rf ${S}/configurations ${D}/${installdir}/
> >> +}
> >> +
> >> +SRC_URI[omapl138.md5sum] = "5a4eb834bde44c662aaf669882adbfe6"
> >> +SRC_URI[omapl138.sha256sum] =
> >> "6701ca0e91761b9eb80b0097fbb2e2ce2cd8e0bcdc0bd18c34cd0221d9d450d0
> >> "
> >> --
> >> 1.7.0.4
> >> 
> >> _______________________________________________
> >> meta-arago mailing list
> >> meta-arago@arago-project.org
> >> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>