All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: kernel-janitors@vger.kernel.org
Subject: Re: [signal:master 62/63] arch/m68k/kernel/entry.S:115: Error: operands mismatch -- statement `movem
Date: Sun, 09 Sep 2012 02:31:45 +0000	[thread overview]
Message-ID: <20120909023145.GL13973@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20120908135733.GA25549@localhost>

On Sun, Sep 09, 2012 at 12:28:17AM +0800, Fengguang Wu wrote:
> > On which toolchain?  It had been a valid instruction on all m68k, starting with
> > 68000.  Is that as(1) insisting on %sp@+ form instead of (%sp)+?  But we have
> > both kinds used in arch/m68k, so if some toolchain version barfs on that, it's
> > probably rather unhappy elsewhere...

Hrrrm....  Looks like it's an effect of weird addressing modes being
somewhat trimmed down on coldfire...  So these lines should become
something like
        moveml  4(%sp), %d1-%d2 
        moveq   #PT_SIZEOF,%d3
        moveml  %d1-%d3,(%sp)   | we are not returning anyway...

With that it still works on aranym and AFAICS those forms should be acceptable
on anything, including all coldfire variants...  As far as I can see, all
places using increment/decrement forms of movem (essentially, bulk push/pop
on arbitrary set of registers) are in the code that never gets touched on
coldfire and non-MMU builds; the only potential exception is non-assembler
variant of SAVE_ALL_INT (#define SAVE_ALL_INT .... in asm/entry.h), but that
macro is never actually used anywhere in C code.

OK, folded and pushed.  Should be on git.kernel.org shortly...

      parent reply	other threads:[~2012-09-09  2:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-08 13:57 [signal:master 62/63] arch/m68k/kernel/entry.S:115: Error: operands mismatch -- statement `moveml (% Fengguang Wu
2012-09-08 14:54 ` [signal:master 62/63] arch/m68k/kernel/entry.S:115: Error: operands mismatch -- statement `movem Al Viro
2012-09-08 16:28 ` Fengguang Wu
2012-09-08 17:48 ` Al Viro
2012-09-08 19:58 ` Al Viro
2012-09-09  2:31 ` Al Viro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120909023145.GL13973@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.