From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-omap@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: New build warnings
Date: Sun, 9 Sep 2012 21:12:40 +0200 [thread overview]
Message-ID: <20120909191240.GV28643@pengutronix.de> (raw)
In-Reply-To: <20120908083849.GA1603@n2100.arm.linux.org.uk>
On Sat, Sep 08, 2012 at 09:38:49AM +0100, Russell King - ARM Linux wrote:
> On Mon, Jul 30, 2012 at 05:44:44PM +0100, Russell King - ARM Linux wrote:
> > Okay, so last night's build run shows some new warnings...
> >
> > drivers/regulator/twl-regulator.c: In function 'twlreg_probe':
> > drivers/regulator/twl-regulator.c:1151: warning: assignment discards qualifiers from pointer target type
> > drivers/regulator/twl-regulator.c:1160: warning: assignment discards qualifiers from pointer target type
> >
> > These two look like missing const - looks like they were introduced by:
> >
> > commit 98d7bbb9929bcc14e11ac8a55245a4f2dc174e17
> > Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > Date: Thu Jun 7 12:20:14 2012 +0200
> >
> > of: add const to struct *of_device_id.data
> >
> > Drivers should never need to modify the data of a device id. So it can
> > be const which in turn allows more consts in the driver.
> >
> > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> I notice this one is still present in the kernel. Uwe, what's happening
> with it?
Yeah, the warning was introduced by my patch. It's not trivial to fix
because the twl-regulator driver modifies the data used to probe devices
during probe. That is the result of two probes might depend on their
order. I mentioned that problem in the cover letter of my series but got
no feedback from someone feeling responsible for this driver.
Arnd sent a patch for that problem, don't know its state though.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-09-09 19:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 16:44 New build warnings Russell King - ARM Linux
2012-07-30 17:40 ` Mark Brown
2012-07-30 18:06 ` Russell King - ARM Linux
2012-07-30 18:40 ` Mark Brown
2012-09-08 8:38 ` Russell King - ARM Linux
2012-09-09 19:12 ` Uwe Kleine-König [this message]
2012-09-09 23:33 ` Mark Brown
2012-09-10 6:40 ` Uwe Kleine-König
2012-09-10 6:42 ` Mark Brown
2012-09-10 7:05 ` Uwe Kleine-König
2012-09-10 7:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120909191240.GV28643@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=arnd@arndb.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.