From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38693)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TB4nJ-0003Mv-CV
	for qemu-devel@nongnu.org; Mon, 10 Sep 2012 10:17:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TB4nC-00010f-Kj
	for qemu-devel@nongnu.org; Mon, 10 Sep 2012 10:16:57 -0400
Received: from hall.aurel32.net ([88.191.126.93]:47393)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TB4nC-00010C-Ek
	for qemu-devel@nongnu.org; Mon, 10 Sep 2012 10:16:50 -0400
Date: Mon, 10 Sep 2012 16:16:48 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20120910141648.GT17750@hall.aurel32.net>
References: <1347224784-19472-1-git-send-email-rth@twiddle.net>
	<1347224784-19472-2-git-send-email-rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1347224784-19472-2-git-send-email-rth@twiddle.net>
Sender: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 001/126] tcg: Add TCGV_IS_UNUSED_*
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

On Sun, Sep 09, 2012 at 02:04:19PM -0700, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> ---
>  tcg/tcg.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tcg/tcg.h b/tcg/tcg.h
> index d710694..a9367fe 100644
> --- a/tcg/tcg.h
> +++ b/tcg/tcg.h
> @@ -251,6 +251,9 @@ typedef int TCGv_i64;
>  #define TCGV_UNUSED_I32(x) x = MAKE_TCGV_I32(-1)
>  #define TCGV_UNUSED_I64(x) x = MAKE_TCGV_I64(-1)
>  
> +#define TCGV_IS_UNUSED_I32(x) (GET_TCGV_I32(x) == -1)
> +#define TCGV_IS_UNUSED_I64(x) (GET_TCGV_I64(x) == -1)
> +
>  /* call flags */
>  /* A pure function only reads its arguments and TCG global variables
>     and cannot raise exceptions. Hence a call to a pure function can be

Looks fine.

Reviewed: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net