From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TB5Ly-0007U5-By for qemu-devel@nongnu.org; Mon, 10 Sep 2012 10:52:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TB5Lx-0004xW-B4 for qemu-devel@nongnu.org; Mon, 10 Sep 2012 10:52:46 -0400 Received: from hall.aurel32.net ([88.191.126.93]:59013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TB5Lx-0004xG-5I for qemu-devel@nongnu.org; Mon, 10 Sep 2012 10:52:45 -0400 Date: Mon, 10 Sep 2012 16:52:43 +0200 From: Aurelien Jarno Message-ID: <20120910145243.GV17750@hall.aurel32.net> References: <1347224784-19472-1-git-send-email-rth@twiddle.net> <1347224784-19472-8-git-send-email-rth@twiddle.net> <20120910143422.GZ6791@ohm.aurel32.net> <504DFCF0.7040109@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <504DFCF0.7040109@twiddle.net> Sender: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH 007/126] target-s390: Use TCG registers for FPR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, Alexander Graf On Mon, Sep 10, 2012 at 07:45:04AM -0700, Richard Henderson wrote: > On 09/10/2012 07:34 AM, Aurelien Jarno wrote: > > If it is not possible to implement your FPR code using these functions, > > we might want to add some more, but I really thing it's a bad idea to > > have this code in the targets. > > I thought I got rid of all this in the various rebasing. Certainly it's > all gone by the end of the patch series. > > In particular, the optimization that I was looking for is handled inside > tcg_gen_deposit_i64, so there's no point in doing this in target code too. > > I'll make sure this is gone from the next revision. Ok, I have to say the series being quite long, I haven't looked at it in details. If they are gone at the end, it's pretty fine for me. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net