From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] NAND: MXS: include common.h first so cache.h is included in correct order
Date: Mon, 10 Sep 2012 18:18:42 +0200 [thread overview]
Message-ID: <201209101818.42532.marex@denx.de> (raw)
In-Reply-To: <1347292557-4478-1-git-send-email-twarren@nvidia.com>
Dear Tom Warren,
> With Simon Glass's include/nand.h alignment changes, some mxs builds
> were generating errors. Fix is to ensure asm/cache.h is included before
> linux/mtd/nand.h. Moving common.h to top of include list does that.
>
> Signed-off-by: Tom Warren <twarren@nvidia.com>
Acked-by: Marek Vasut <marex@denx.de>
Ccing Stefano.
> ---
> drivers/mtd/nand/mxs_nand.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/mxs_nand.c b/drivers/mtd/nand/mxs_nand.c
> index bf9414f..4701be8 100644
> --- a/drivers/mtd/nand/mxs_nand.c
> +++ b/drivers/mtd/nand/mxs_nand.c
> @@ -25,10 +25,10 @@
> * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> */
>
> +#include <common.h>
> #include <linux/mtd/mtd.h>
> #include <linux/mtd/nand.h>
> #include <linux/types.h>
> -#include <common.h>
> #include <malloc.h>
> #include <asm/errno.h>
> #include <asm/io.h>
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-09-10 16:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 15:55 [U-Boot] [PATCH] NAND: MXS: include common.h first so cache.h is included in correct order Tom Warren
2012-09-10 15:58 ` Simon Glass
2012-09-10 16:18 ` Marek Vasut [this message]
2012-09-10 20:20 ` Tom Warren
2012-09-11 4:32 ` stefano babic
2012-09-11 6:52 ` Marek Vasut
2012-09-11 7:44 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209101818.42532.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.