From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frederic Weisbecker Subject: Re: [PATCH 00/11] rcu: Add missing RCU idle APIs on idle loop v2 Date: Mon, 10 Sep 2012 23:53:01 +0200 Message-ID: <20120910215244.GD21277@somewhere.redhat.com> References: <1345733915-20040-1-git-send-email-fweisbec@gmail.com> <20120824212647.GU2472@linux.vnet.ibm.com> <1345857554.4840.43.camel@deadeye.wl.decadent.org.uk> <20120825035047.GB3436@linux.vnet.ibm.com> <20120825131647.GA1994@somewhere> <20120825161806.GD3436@linux.vnet.ibm.com> <5039406F.9040604@orcon.net.nz> <20120826001233.GH3436@linux.vnet.ibm.com> <20120826092137.GA50543@kaini.schwarzvogel.de> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=pKLiyDpnErQkla0nMUx8aRpOih2bNXqclIwgi3khx9E=; b=Pt8uC/FyHmlmrgnMTrDJ6ozKLYP5ANKPHQ8YmnlYbeW96sgtXkbM/ZcL+WXzFTGz7d NNAlxUL4wsc5x4T++IyiNF8uR9l7LBXcJbjrwqxzAYawwbqw4WJyNnSqRClgMjHGSKJt 1zHpIFr0/MnLXnW7XAwTVE8/CUuX0TssM6V9fcHszFQ4QlVV8y8Qzsh+ngu/yBmKWBCX ywc0IvBWipiOSoJLeR+Qw6LMHTdgTSVeyJB/9mevOh8Yplk0W9Xin242R7bVIVb/HOyR wVaETEyaxrY0sdgS/s2+tmhB9Wr15T6T3owOkLjqLXznOzeMcC0oj02VirCul5MVHvef VjtQ== Content-Disposition: inline In-Reply-To: <20120826092137.GA50543@kaini.schwarzvogel.de> Sender: linux-parisc-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Paul E. McKenney" , Michael Cree , Ben Hutchings , LKML , Chris Zankel , "3.2.x.." , Chen Liqin , Lennox Wu , "James E.J. Bottomley" , Helge Deller , Parisc , David Howells , Koichi Yasutake , Geert Uytterhoeven , m68k , Hirokazu Takata , Yoshinori Sato , Mikael Starvik , Jesper Nilsson , Cris , Richard Henderson , Ivan Kokshaysky , Matt On Sun, Aug 26, 2012 at 11:21:37AM +0200, Tobias Klausmann wrote: > Hi! > > On Sat, 25 Aug 2012, Paul E. McKenney wrote: > > Both Alpha patches should apply as-is back to 3.3, and should also fix > > the problem. Could you please check this on the versions of interest? > > I just now tried them on top of 3.3.8 from linux-stable.git. > While they apply cleanly, I get a compile failure: > > CC arch/alpha/kernel/process.o > arch/alpha/kernel/process.c: In function 'cpu_idle': > arch/alpha/kernel/process.c:64: error: implicit declaration of function 'schedule_preempt_disabled' > make[1]: *** [arch/alpha/kernel/process.o] Error 1 > make: *** [arch/alpha/kernel] Error 2 > > AFAICT, schedule_preempt_disabled() was only introduced in 3.4 > and thus needs to be backported for 3.3. Please try with this instead: preempt_enable_no_resched(); schedule(); preempt_disable(); Thanks. > > Regards, > Tobias > > -- > panic("%s: CORRUPTED BTREE OR SOMETHING", __FUNCTION__); > linux-2.6.6/fs/xfs/xfs_bmap.c From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frederic Weisbecker Subject: Re: [PATCH 00/11] rcu: Add missing RCU idle APIs on idle loop v2 Date: Mon, 10 Sep 2012 23:53:01 +0200 Message-ID: <20120910215244.GD21277@somewhere.redhat.com> References: <1345733915-20040-1-git-send-email-fweisbec@gmail.com> <20120824212647.GU2472@linux.vnet.ibm.com> <1345857554.4840.43.camel@deadeye.wl.decadent.org.uk> <20120825035047.GB3436@linux.vnet.ibm.com> <20120825131647.GA1994@somewhere> <20120825161806.GD3436@linux.vnet.ibm.com> <5039406F.9040604@orcon.net.nz> <20120826001233.GH3436@linux.vnet.ibm.com> <20120826092137.GA50543@kaini.schwarzvogel.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: "Paul E. McKenney" , Michael Cree , Ben Hutchings , LKML , Chris Zankel , "3.2.x.." , Chen Liqin , Lennox Wu , "James E.J. Bottomley" , Helge Deller , Parisc , David Howells , Koichi Yasutake , Geert Uytterhoeven , m68k , Hirokazu Takata , Yoshinori Sato , Mikael Starvik , Jesper Nilsson , Cris , Richard Henderson , Ivan Kokshaysky , Matt Tu Return-path: In-Reply-To: <20120826092137.GA50543@kaini.schwarzvogel.de> List-ID: List-Id: linux-parisc.vger.kernel.org On Sun, Aug 26, 2012 at 11:21:37AM +0200, Tobias Klausmann wrote: > Hi! > > On Sat, 25 Aug 2012, Paul E. McKenney wrote: > > Both Alpha patches should apply as-is back to 3.3, and should also fix > > the problem. Could you please check this on the versions of interest? > > I just now tried them on top of 3.3.8 from linux-stable.git. > While they apply cleanly, I get a compile failure: > > CC arch/alpha/kernel/process.o > arch/alpha/kernel/process.c: In function 'cpu_idle': > arch/alpha/kernel/process.c:64: error: implicit declaration of function 'schedule_preempt_disabled' > make[1]: *** [arch/alpha/kernel/process.o] Error 1 > make: *** [arch/alpha/kernel] Error 2 > > AFAICT, schedule_preempt_disabled() was only introduced in 3.4 > and thus needs to be backported for 3.3. Please try with this instead: preempt_enable_no_resched(); schedule(); preempt_disable(); Thanks. > > Regards, > Tobias > > -- > panic("%s: CORRUPTED BTREE OR SOMETHING", __FUNCTION__); > linux-2.6.6/fs/xfs/xfs_bmap.c From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756845Ab2IJVxN (ORCPT ); Mon, 10 Sep 2012 17:53:13 -0400 Received: from mail-vc0-f174.google.com ([209.85.220.174]:37086 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751460Ab2IJVxI (ORCPT ); Mon, 10 Sep 2012 17:53:08 -0400 Date: Mon, 10 Sep 2012 23:53:01 +0200 From: Frederic Weisbecker To: "Paul E. McKenney" , Michael Cree , Ben Hutchings , LKML , Chris Zankel , "3.2.x.." , Chen Liqin , Lennox Wu , "James E.J. Bottomley" , Helge Deller , Parisc , David Howells , Koichi Yasutake , Geert Uytterhoeven , m68k , Hirokazu Takata , Yoshinori Sato , Mikael Starvik , Jesper Nilsson , Cris , Richard Henderson , Ivan Kokshaysky , Matt Turner , alpha Subject: Re: [PATCH 00/11] rcu: Add missing RCU idle APIs on idle loop v2 Message-ID: <20120910215244.GD21277@somewhere.redhat.com> References: <1345733915-20040-1-git-send-email-fweisbec@gmail.com> <20120824212647.GU2472@linux.vnet.ibm.com> <1345857554.4840.43.camel@deadeye.wl.decadent.org.uk> <20120825035047.GB3436@linux.vnet.ibm.com> <20120825131647.GA1994@somewhere> <20120825161806.GD3436@linux.vnet.ibm.com> <5039406F.9040604@orcon.net.nz> <20120826001233.GH3436@linux.vnet.ibm.com> <20120826092137.GA50543@kaini.schwarzvogel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120826092137.GA50543@kaini.schwarzvogel.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 26, 2012 at 11:21:37AM +0200, Tobias Klausmann wrote: > Hi! > > On Sat, 25 Aug 2012, Paul E. McKenney wrote: > > Both Alpha patches should apply as-is back to 3.3, and should also fix > > the problem. Could you please check this on the versions of interest? > > I just now tried them on top of 3.3.8 from linux-stable.git. > While they apply cleanly, I get a compile failure: > > CC arch/alpha/kernel/process.o > arch/alpha/kernel/process.c: In function 'cpu_idle': > arch/alpha/kernel/process.c:64: error: implicit declaration of function 'schedule_preempt_disabled' > make[1]: *** [arch/alpha/kernel/process.o] Error 1 > make: *** [arch/alpha/kernel] Error 2 > > AFAICT, schedule_preempt_disabled() was only introduced in 3.4 > and thus needs to be backported for 3.3. Please try with this instead: preempt_enable_no_resched(); schedule(); preempt_disable(); Thanks. > > Regards, > Tobias > > -- > panic("%s: CORRUPTED BTREE OR SOMETHING", __FUNCTION__); > linux-2.6.6/fs/xfs/xfs_bmap.c