All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Luis Gonzalez Fernandez <luisgf@gmail.com>
Cc: lrg@ti.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] regulator: Fix incorrect casting in tps6230-regulator.c
Date: Tue, 11 Sep 2012 08:09:27 +0800	[thread overview]
Message-ID: <20120911000925.GC30699@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1347310409-25976-1-git-send-email-luisgf@gmail.com>

On Mon, Sep 10, 2012 at 10:53:29PM +0200, Luis Gonzalez Fernandez wrote:
> linux-3.6/drivers/regulator/tps62360-regulator.c: In function ‘tps62360_probe’:
> linux-3.6/drivers/regulator/tps62360-regulator.c:364:13: warning: cast from poi$
> 
> Fix incorrect cast in tps62360_probe() function.

This fix isn't at all obvious and the warning doesn't show up for me.
In general you need to supply some words explaining what you're doing,
simply pasting a copy of an error message doesn't explain why your new
code is good.

      reply	other threads:[~2012-09-11  0:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-10 20:53 [PATCH 1/1] regulator: Fix incorrect casting in tps6230-regulator.c Luis Gonzalez Fernandez
2012-09-11  0:09 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120911000925.GC30699@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=luisgf@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.