From: Greg KH <gregkh@linuxfoundation.org>
To: Joe Perches <joe@perches.com>
Cc: Bruce Humphrey <brucehum@gmail.com>,
abbotti@mev.co.uk, fmhess@users.sourceforge.net,
hsweeten@visionengravers.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: drivers: fl512: change printk(KERN_INFO ... for the prefered pr_info(...
Date: Mon, 10 Sep 2012 20:44:57 -0700 [thread overview]
Message-ID: <20120911034457.GA3317@kroah.com> (raw)
In-Reply-To: <1347334811.2073.2.camel@joe2Laptop>
On Mon, Sep 10, 2012 at 08:40:11PM -0700, Joe Perches wrote:
> On Mon, 2012-09-10 at 19:52 -0700, Greg KH wrote:
> > On Tue, Sep 11, 2012 at 04:50:15AM +0200, Bruce Humphrey wrote:
> > > Change 5 instances of printk(KERN_INFO, KERN_WARN and KERN_ERROR for the prefered pr_info, pr_warn and pr_error
> []
> > > diff --git a/drivers/staging/comedi/drivers/fl512.c b/drivers/staging/comedi/drivers/fl512.c
> []
> > > @@ -118,9 +118,9 @@ static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> []
> > > - printk(KERN_INFO "comedi:%d fl512: 0x%04lx", dev->minor, iobase);
> > > + pr_info("comedi:%d fl512: 0x%04lx", dev->minor, iobase);
> >
> > Why can't you use dev_info() here, and in other places? You should use
> > the dev_* functions instead of pr_* wherever possible.
>
> Checkpatch instigates these conversions.
I know.
> Perhaps something like:
That looks like a good start, until someone tries to use netdev_* in a
random non-network driver :)
greg k-h
next prev parent reply other threads:[~2012-09-11 3:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 2:50 [PATCH] Staging: comedi: drivers: fl512: change printk(KERN_INFO ... for the prefered pr_info( Bruce Humphrey
2012-09-11 2:52 ` Greg KH
2012-09-11 3:40 ` Joe Perches
2012-09-11 3:44 ` Greg KH [this message]
2012-09-11 3:48 ` Joe Perches
2012-09-11 11:02 ` Dan Carpenter
2012-09-11 15:19 ` [PATCH] checkpatch: Update suggested printk conversions Joe Perches
2012-09-11 10:59 ` [PATCH] Staging: comedi: drivers: fl512: change printk(KERN_INFO ... for the prefered pr_info( Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120911034457.GA3317@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=brucehum@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=fmhess@users.sourceforge.net \
--cc=hsweeten@visionengravers.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.