From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Boris Ranto <ranto.boris@gmail.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH v3] Add test case to test xfs projid32bit functionality a bit more extensively.
Date: Tue, 11 Sep 2012 13:45:10 +1000 [thread overview]
Message-ID: <20120911034510.GA11511@dastard> (raw)
In-Reply-To: <504EA627.2050906@sandeen.net>
On Mon, Sep 10, 2012 at 09:47:03PM -0500, Eric Sandeen wrote:
> On 9/6/12 10:23 AM, Boris Ranto wrote:
> > The test covers several areas including enabling projid32bit
> > functionality dynamically by xfs_admin, dumping, restoring, quota
> > reporting and xfs_db projid values reporting.
> > This test case hits a bug with xfsdump/xfsrestore process on a
> > projid32bit enabled filesystem.
> >
> > Signed-off-by: Boris Ranto <ranto.boris@gmail.com>
>
> there are just a couple things below, but I think we can get it
> checked in unless Dave has further concerns - please see below.
....
> > +dir=$SCRATCH_MNT/pquota
> > +
> > +status=1
> > +
> > +mkdir -p $dir
> > +touch $dir/{16,32}less
>
> Although I understand it ok, I might add a comment here saying:
>
> # create files to hold 16 and 32-bit project IDs
>
> In retrospect I might use 16bit and 32bit to make more sense.
> Sorry, should have suggested that earlier.
>
> I could just change the names on checkin with a note if that's ok with you.
With that change to 16bit/32bit, it's fine by me.
> > @@ -403,3 +403,4 @@ deprecated
> > 282 dump ioctl auto quick
> > 283 dump ioctl auto quick
> > 284 auto
> > +285 auto dump quota
Like I mentione dfirst time around, it needs to be added to the
quick group as well.
If you make those changes, Eric, then consider it:
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-09-11 3:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 15:23 [PATCH v3] Add test case to test xfs projid32bit functionality a bit more extensively Boris Ranto
2012-09-11 2:47 ` Eric Sandeen
2012-09-11 3:10 ` Eric Sandeen
2012-09-11 3:45 ` Dave Chinner [this message]
2012-09-11 3:48 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120911034510.GA11511@dastard \
--to=david@fromorbit.com \
--cc=ranto.boris@gmail.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.