From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] sensors: add humidity data to output of sensors command
Date: Tue, 11 Sep 2012 04:17:27 +0000 [thread overview]
Message-ID: <20120911041727.GA450@roeck-us.net> (raw)
In-Reply-To: <4FE063E1.5050301@gmail.com>
Hi Jean,
On Tue, Jun 19, 2012 at 11:34:57AM +0000, Iain Paton wrote:
> Testing out a humidity sensor recently and was thinking the driver wasn't working somehow.
> Discovered instead that the driver works fine, but the sensors command was ignoring the
> humidity data.
> This adds output of humidity data for sensors that support it.
>
> Please consider applying it.
>
> Thanks,
> Iain
>
mind if I apply this patch to lm-sensors ?
Thanks,
Guenter
> diff -Naur lm_sensors-3.3.2-org/prog/sensors/chips.c lm_sensors-3.3.2/prog/sensors/chips.c
> --- lm_sensors-3.3.2-org/prog/sensors/chips.c 2012-03-07 16:12:56.000000000 +0000
> +++ lm_sensors-3.3.2/prog/sensors/chips.c 2012-06-18 17:35:15.769803432 +0100
> @@ -658,6 +658,27 @@
> free(label);
> }
>
> +static void print_chip_humidity(const sensors_chip_name *name,
> + const sensors_feature *feature,
> + int label_size)
> +{
> + char *label;
> + const sensors_subfeature *subfeature;
> + double vid;
> +
> + subfeature = sensors_get_subfeature(name, feature,
> + SENSORS_SUBFEATURE_HUMIDITY_INPUT);
> + if (!subfeature)
> + return;
> +
> + if ((label = sensors_get_label(name, feature))
> + && !sensors_get_value(name, subfeature->number, &vid)) {
> + print_label(label, label_size);
> + printf("%6.1f \%RH\n", vid);
> + }
> + free(label);
> +}
> +
> static void print_chip_beep_enable(const sensors_chip_name *name,
> const sensors_feature *feature,
> int label_size)
> @@ -792,6 +813,9 @@
> case SENSORS_FEATURE_INTRUSION:
> print_chip_intrusion(name, feature, label_size);
> break;
> + case SENSORS_FEATURE_HUMIDITY:
> + print_chip_humidity(name, feature, label_size);
> + break;
> default:
> continue;
> }
>
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
>
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2012-09-11 4:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-19 11:34 [lm-sensors] [PATCH] sensors: add humidity data to output of sensors command Iain Paton
2012-09-11 4:17 ` Guenter Roeck [this message]
2012-09-11 7:04 ` Jean Delvare
2012-09-11 19:06 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120911041727.GA450@roeck-us.net \
--to=linux@roeck-us.net \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.