All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: kirkwood: Trim excess #includes in board-dnskw.c
Date: Tue, 11 Sep 2012 07:09:22 +0200	[thread overview]
Message-ID: <20120911050922.GA6836@lunn.ch> (raw)
In-Reply-To: <1347287753-2805-1-git-send-email-jm@lentin.co.uk>

On Mon, Sep 10, 2012 at 03:35:53PM +0100, Jamie Lentin wrote:
> Lots of code has now moved into the devicetree, leaving a collection of
> useless header files. Tidy them up.
> 
> This applies cleanly atop of my previous patch, "[PATCH V2 2/2] ARM:
> kirkwood: Use devicetree to define DNS-32[05] fan", which also removes
> gpio-fan.h
> 
> Signed-off-by: Jamie Lentin <jm@lentin.co.uk>
> ---
>  arch/arm/mach-kirkwood/board-dnskw.c |    9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/arch/arm/mach-kirkwood/board-dnskw.c b/arch/arm/mach-kirkwood/board-dnskw.c
> index 6ac7a8d..43d16d6 100644
> --- a/arch/arm/mach-kirkwood/board-dnskw.c
> +++ b/arch/arm/mach-kirkwood/board-dnskw.c
> @@ -14,17 +14,8 @@
>  #include <linux/kernel.h>
>  #include <linux/init.h>
>  #include <linux/platform_device.h>
> -#include <linux/ata_platform.h>
>  #include <linux/mv643xx_eth.h>
> -#include <linux/of.h>
>  #include <linux/gpio.h>
> -#include <linux/input.h>
> -#include <linux/leds.h>
> -#include <asm/mach-types.h>
> -#include <asm/mach/arch.h>
> -#include <asm/mach/map.h>
> -#include <mach/kirkwood.h>
> -#include <mach/bridge-regs.h>
>  #include "common.h"
>  #include "mpp.h"

Acked-by: Andrew Lunn <andrew@lunn.ch>

Hi Jamie

A minor point. I personally would of based this patch on top of a
plain -rc tag and not on top of the gpio-fan code. The gpio-fan code
might need more revisions before its acceptable, where as this change
is very likely to be accepted first time and is not controversial in
any way. So Jason is likely to apply this now, before the gpio-fan
code hits.

     Andrew

      reply	other threads:[~2012-09-11  5:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-10 14:35 [PATCH] ARM: kirkwood: Trim excess #includes in board-dnskw.c Jamie Lentin
2012-09-11  5:09 ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120911050922.GA6836@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.