All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: kirkwood: Trim excess #includes in board-dnskw.c
@ 2012-09-10 14:35 Jamie Lentin
  2012-09-11  5:09 ` Andrew Lunn
  0 siblings, 1 reply; 2+ messages in thread
From: Jamie Lentin @ 2012-09-10 14:35 UTC (permalink / raw)
  To: linux-arm-kernel

Lots of code has now moved into the devicetree, leaving a collection of
useless header files. Tidy them up.

This applies cleanly atop of my previous patch, "[PATCH V2 2/2] ARM:
kirkwood: Use devicetree to define DNS-32[05] fan", which also removes
gpio-fan.h

Signed-off-by: Jamie Lentin <jm@lentin.co.uk>
---
 arch/arm/mach-kirkwood/board-dnskw.c |    9 ---------
 1 file changed, 9 deletions(-)

diff --git a/arch/arm/mach-kirkwood/board-dnskw.c b/arch/arm/mach-kirkwood/board-dnskw.c
index 6ac7a8d..43d16d6 100644
--- a/arch/arm/mach-kirkwood/board-dnskw.c
+++ b/arch/arm/mach-kirkwood/board-dnskw.c
@@ -14,17 +14,8 @@
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/platform_device.h>
-#include <linux/ata_platform.h>
 #include <linux/mv643xx_eth.h>
-#include <linux/of.h>
 #include <linux/gpio.h>
-#include <linux/input.h>
-#include <linux/leds.h>
-#include <asm/mach-types.h>
-#include <asm/mach/arch.h>
-#include <asm/mach/map.h>
-#include <mach/kirkwood.h>
-#include <mach/bridge-regs.h>
 #include "common.h"
 #include "mpp.h"
 
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: kirkwood: Trim excess #includes in board-dnskw.c
  2012-09-10 14:35 [PATCH] ARM: kirkwood: Trim excess #includes in board-dnskw.c Jamie Lentin
@ 2012-09-11  5:09 ` Andrew Lunn
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2012-09-11  5:09 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Sep 10, 2012 at 03:35:53PM +0100, Jamie Lentin wrote:
> Lots of code has now moved into the devicetree, leaving a collection of
> useless header files. Tidy them up.
> 
> This applies cleanly atop of my previous patch, "[PATCH V2 2/2] ARM:
> kirkwood: Use devicetree to define DNS-32[05] fan", which also removes
> gpio-fan.h
> 
> Signed-off-by: Jamie Lentin <jm@lentin.co.uk>
> ---
>  arch/arm/mach-kirkwood/board-dnskw.c |    9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/arch/arm/mach-kirkwood/board-dnskw.c b/arch/arm/mach-kirkwood/board-dnskw.c
> index 6ac7a8d..43d16d6 100644
> --- a/arch/arm/mach-kirkwood/board-dnskw.c
> +++ b/arch/arm/mach-kirkwood/board-dnskw.c
> @@ -14,17 +14,8 @@
>  #include <linux/kernel.h>
>  #include <linux/init.h>
>  #include <linux/platform_device.h>
> -#include <linux/ata_platform.h>
>  #include <linux/mv643xx_eth.h>
> -#include <linux/of.h>
>  #include <linux/gpio.h>
> -#include <linux/input.h>
> -#include <linux/leds.h>
> -#include <asm/mach-types.h>
> -#include <asm/mach/arch.h>
> -#include <asm/mach/map.h>
> -#include <mach/kirkwood.h>
> -#include <mach/bridge-regs.h>
>  #include "common.h"
>  #include "mpp.h"

Acked-by: Andrew Lunn <andrew@lunn.ch>

Hi Jamie

A minor point. I personally would of based this patch on top of a
plain -rc tag and not on top of the gpio-fan code. The gpio-fan code
might need more revisions before its acceptable, where as this change
is very likely to be accepted first time and is not controversial in
any way. So Jason is likely to apply this now, before the gpio-fan
code hits.

     Andrew

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-09-11  5:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-10 14:35 [PATCH] ARM: kirkwood: Trim excess #includes in board-dnskw.c Jamie Lentin
2012-09-11  5:09 ` Andrew Lunn

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.