All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Ansis Atteka <aatteka@nicira.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] conntrackd: make conntrackd namespace aware
Date: Tue, 11 Sep 2012 17:44:58 +0200	[thread overview]
Message-ID: <20120911154458.GB28012@1984> (raw)
In-Reply-To: <CAA=3Oq=G9g=9LkKxhobU1cTLtU3jyuGJZn4kn_E4LJXk11Escw@mail.gmail.com>

On Mon, Sep 10, 2012 at 04:24:49PM -0700, Ansis Atteka wrote:
[...]
> >
> >> +
> >> +#ifdef __NR_setns
> >> +
> >> +static int root_fd = -1;
> >
> > This root_fd should go to STATE(ns).root_fd:
>
> Right, it makes more sense to put it inside ct_state for
> now.
> 
> Once conntrackd will become multi-namespace
> aware, we will have to move it somewhere else,
> because all the namespaces(i.e. ct_states) will
> use the same root_fd.

Can you develop a bit more the change that should happen in your
opinion) to conntrackd to support multi-namespace? I'd like to get an
idea before that patch lands on the mailing list.

[...]
> Thanks for review! I will send updated patch soon.

Thanks.

  reply	other threads:[~2012-09-11 18:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-01  1:11 [PATCH] conntrackd: make conntrackd namespace aware Ansis Atteka
2012-09-06  1:36 ` Ansis Atteka
2012-09-06 17:17   ` Pablo Neira Ayuso
2012-09-06 20:33     ` Ansis Atteka
2012-09-06 17:02 ` Pablo Neira Ayuso
2012-09-10 23:24   ` Ansis Atteka
2012-09-11 15:44     ` Pablo Neira Ayuso [this message]
2012-09-13  7:37       ` Ansis Atteka
2012-09-18 19:23         ` Pablo Neira Ayuso
2012-09-18 22:36           ` Ansis Atteka
2012-09-19  8:21             ` Pablo Neira Ayuso
2012-09-28 20:05               ` Ansis Atteka
2012-10-16  4:55               ` Ansis Atteka
2012-11-15 12:20                 ` Pablo Neira Ayuso
2012-11-15 19:34                   ` Ansis Atteka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120911154458.GB28012@1984 \
    --to=pablo@netfilter.org \
    --cc=aatteka@nicira.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.