From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] If linux-pam is built, enable dbm functionality in Berkeley DB
Date: Tue, 11 Sep 2012 16:32:08 +0200 [thread overview]
Message-ID: <20120911163208.3e9d23b3@skate> (raw)
In-Reply-To: <1347078066-25257-1-git-send-email-golubovsky@gmail.com>
Le Sat, 8 Sep 2012 00:21:03 -0400,
Dmitry <golubovsky@gmail.com> a ?crit :
> + $(if $(BR2_PACKAGE_LINUX_PAM),--enable-dbm,--disable-dbm) \
I don't really like this. I think you should rather add a configuration
sub-option in package/berkeleydb/Config.in to enable/disable DBM
support, and then have berkeleydb.mk test this configuration option,
and the linux-pam/Config.in package select it.
I don't like when one package recipe pokes into the configuration
options of another package.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-09-11 14:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-08 4:21 [Buildroot] [PATCH 1/4] If linux-pam is built, enable dbm functionality in Berkeley DB Dmitry
2012-09-08 4:21 ` [Buildroot] [PATCH 2/4] Make Berkeley DB a dependency of linux-pam and make sure it is selected Dmitry
2012-09-11 14:32 ` Thomas Petazzoni
2012-09-11 14:44 ` Dmitry Golubovsky
2012-09-11 14:45 ` Thomas Petazzoni
2012-09-11 19:18 ` Arnout Vandecappelle
2012-09-11 19:52 ` Dmitry Golubovsky
2012-09-12 5:31 ` Arnout Vandecappelle
2012-09-12 9:30 ` Dmitry Golubovsky
2012-09-08 4:21 ` [Buildroot] [PATCH 3/4] Provide PAM default configuration files when building linux-pam package Dmitry
2012-09-08 4:21 ` [Buildroot] [PATCH 4/4] PAM support in Busybox if linux-pam is built Dmitry
2012-09-11 14:32 ` Thomas Petazzoni [this message]
2012-09-11 14:46 ` [Buildroot] [PATCH 1/4] If linux-pam is built, enable dbm functionality in Berkeley DB Dmitry Golubovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120911163208.3e9d23b3@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.