From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH REPOST RFC cgroup/for-3.7] cgroup: mark subsystems with broken hierarchy support and whine if cgroups are nested for them Date: Tue, 11 Sep 2012 10:08:37 -0700 Message-ID: <20120911170837.GM7677@google.com> References: <20120910223125.GC7677@google.com> <20120910223355.GD7677@google.com> <504F30DB.60808@huawei.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=iZ60cPebjF/E/aPf5o/SMjRFhJbX0YiW+ocY2p4/n18=; b=RfOJiiSZKwzNI3Ldv/FeJkehEMy7SkVRtVyilcv4MrKuvxqm95gGfo6HsWjBCLwTjT q/1H73l/H9sWvz+hmcPKKwjTmusBtFfOJlgtilZZQPpefHqX1l5e/ZRK56K1FSAPr8Nz 8hgjDWYcZ+6ECZ66V3IvQUq26cwp1J2TdnJGZmJXYEUEkQW7VQoecffqnz9Cmx2sgsRW uUlgGEKRr5oRWw0eStuqJBiLo/xDHEKRMTwN7mj2Ql29Sb19zFh39wtcHaWOAnlKcj1P dNppvZkd+ajHBX0vK63/9brQi/l72VtgR1CCdXAnL6uxbvVIGRVAI4j/Fu1TSBaZzEXk doCw== Content-Disposition: inline In-Reply-To: <504F30DB.60808-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Li Zefan Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Michal Hocko , Glauber Costa , Peter Zijlstra , Paul Turner , Johannes Weiner , Thomas Graf , "Serge E. Hallyn" , Vivek Goyal , Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo , Neil Horman , "Aneesh Kumar K.V" Hello, Li. On Tue, Sep 11, 2012 at 08:38:51PM +0800, Li Zefan wrote: > > (I tried to document what's broken and how it should be fixed. If I > > got something wrong, please let me know.) > > > > So isn't cpuset broken too? child cpuset's cpu mask isn't necessary a subset > of the parent's if the cpu_exclusive flag is not set. Heh, didn't even look at that. Just assumed it was in the same boat w/ cpu{acct}. Will take a look. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758926Ab2IKRIo (ORCPT ); Tue, 11 Sep 2012 13:08:44 -0400 Received: from mail-iy0-f174.google.com ([209.85.210.174]:64171 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756348Ab2IKRIm (ORCPT ); Tue, 11 Sep 2012 13:08:42 -0400 Date: Tue, 11 Sep 2012 10:08:37 -0700 From: Tejun Heo To: Li Zefan Cc: linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, cgroups@vger.kernel.org, Michal Hocko , Glauber Costa , Peter Zijlstra , Paul Turner , Johannes Weiner , Thomas Graf , "Serge E. Hallyn" , Vivek Goyal , Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo , Neil Horman , "Aneesh Kumar K.V" Subject: Re: [PATCH REPOST RFC cgroup/for-3.7] cgroup: mark subsystems with broken hierarchy support and whine if cgroups are nested for them Message-ID: <20120911170837.GM7677@google.com> References: <20120910223125.GC7677@google.com> <20120910223355.GD7677@google.com> <504F30DB.60808@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <504F30DB.60808@huawei.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Li. On Tue, Sep 11, 2012 at 08:38:51PM +0800, Li Zefan wrote: > > (I tried to document what's broken and how it should be fixed. If I > > got something wrong, please let me know.) > > > > So isn't cpuset broken too? child cpuset's cpu mask isn't necessary a subset > of the parent's if the cpu_exclusive flag is not set. Heh, didn't even look at that. Just assumed it was in the same boat w/ cpu{acct}. Will take a look. Thanks. -- tejun