All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Matt Porter <mporter@ti.com>
Cc: Linux OMAP List <linux-omap@vger.kernel.org>,
	Linux SPI Devel List <spi-devel-general@lists.sourceforge.net>,
	Grant Likely <grant.likely@secretlab.ca>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
	AnilKumar <anilkumar@ti.com>
Subject: Re: [PATCH 2/2] ARM: OMAP2+: Enable pinctrl dummy states
Date: Tue, 11 Sep 2012 11:03:06 -0700	[thread overview]
Message-ID: <20120911180306.GI23092@atomide.com> (raw)
In-Reply-To: <1347385599-27558-3-git-send-email-mporter@ti.com>

* Matt Porter <mporter@ti.com> [120911 10:46]:
> Enable pinctrl dummy states for all OMAP platforms. This allows
> drivers to be converted to pinctrl while still running on
> platforms that do not provide pinctrl data.
> 
> Signed-off-by: Matt Porter <mporter@ti.com>
> ---
>  arch/arm/mach-omap2/devices.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> index c00c689..577cd04 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -17,6 +17,7 @@
>  #include <linux/err.h>
>  #include <linux/slab.h>
>  #include <linux/of.h>
> +#include <linux/pinctrl/machine.h>
>  #include <linux/platform_data/omap4-keypad.h>
>  
>  #include <mach/hardware.h>
> @@ -631,6 +632,9 @@ static inline void omap_init_vout(void) {}
>  
>  static int __init omap2_init_devices(void)
>  {
> +	/* Enable dummy states for those platforms without pinctrl support */
> +	pinctrl_provide_dummies();
> +
>  	/*
>  	 * please keep these calls, and their implementations above,
>  	 * in alphabetical order so they're easier to sort through.

Hmm I think this may need to be board specific. And may need to
be board specific and depend on unpopulated device tree?

For board-generic.c we always want to see the warnings. And some boards
insist on doing all the muxing only in the bootloader.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: OMAP2+: Enable pinctrl dummy states
Date: Tue, 11 Sep 2012 11:03:06 -0700	[thread overview]
Message-ID: <20120911180306.GI23092@atomide.com> (raw)
In-Reply-To: <1347385599-27558-3-git-send-email-mporter@ti.com>

* Matt Porter <mporter@ti.com> [120911 10:46]:
> Enable pinctrl dummy states for all OMAP platforms. This allows
> drivers to be converted to pinctrl while still running on
> platforms that do not provide pinctrl data.
> 
> Signed-off-by: Matt Porter <mporter@ti.com>
> ---
>  arch/arm/mach-omap2/devices.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> index c00c689..577cd04 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -17,6 +17,7 @@
>  #include <linux/err.h>
>  #include <linux/slab.h>
>  #include <linux/of.h>
> +#include <linux/pinctrl/machine.h>
>  #include <linux/platform_data/omap4-keypad.h>
>  
>  #include <mach/hardware.h>
> @@ -631,6 +632,9 @@ static inline void omap_init_vout(void) {}
>  
>  static int __init omap2_init_devices(void)
>  {
> +	/* Enable dummy states for those platforms without pinctrl support */
> +	pinctrl_provide_dummies();
> +
>  	/*
>  	 * please keep these calls, and their implementations above,
>  	 * in alphabetical order so they're easier to sort through.

Hmm I think this may need to be board specific. And may need to
be board specific and depend on unpopulated device tree?

For board-generic.c we always want to see the warnings. And some boards
insist on doing all the muxing only in the bootloader.

Regards,

Tony

  reply	other threads:[~2012-09-11 18:03 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-11 17:46 [PATCH 0/2] Add pinctrl support to omap2-mcspi Matt Porter
2012-09-11 17:46 ` Matt Porter
2012-09-11 17:46 ` Matt Porter
     [not found] ` <1347385599-27558-1-git-send-email-mporter-l0cyMroinI0@public.gmane.org>
2012-09-11 17:46   ` [PATCH 1/2] spi: omap2-mcspi: add pinctrl support Matt Porter
2012-09-11 17:46     ` Matt Porter
2012-09-11 17:46     ` Matt Porter
     [not found]     ` <1347385599-27558-2-git-send-email-mporter-l0cyMroinI0@public.gmane.org>
2012-09-11 18:00       ` Tony Lindgren
2012-09-11 18:00         ` Tony Lindgren
2012-09-11 18:00         ` Tony Lindgren
     [not found]         ` <20120911180041.GH23092-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2012-09-11 18:06           ` Matt Porter
2012-09-11 18:06             ` Matt Porter
2012-09-11 18:06             ` Matt Porter
2012-09-11 17:46   ` [PATCH 2/2] ARM: OMAP2+: Enable pinctrl dummy states Matt Porter
2012-09-11 17:46     ` Matt Porter
2012-09-11 17:46     ` Matt Porter
2012-09-11 18:03     ` Tony Lindgren [this message]
2012-09-11 18:03       ` Tony Lindgren
     [not found]       ` <20120911180306.GI23092-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2012-09-11 18:15         ` Matt Porter
2012-09-11 18:15           ` Matt Porter
2012-09-11 18:15           ` Matt Porter
2012-09-11 18:35           ` Tony Lindgren
2012-09-11 18:35             ` Tony Lindgren
     [not found]             ` <20120911183522.GL23092-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2012-09-11 19:06               ` Matt Porter
2012-09-11 19:06                 ` Matt Porter
2012-09-11 19:06                 ` Matt Porter
2012-09-12  1:03                 ` Tony Lindgren
2012-09-12  1:03                   ` Tony Lindgren
2012-09-12  1:03                   ` Tony Lindgren
     [not found]                   ` <20120912010307.GP23092-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2012-09-17 17:07                     ` Matt Porter
2012-09-17 17:07                       ` Matt Porter
2012-09-17 17:07                       ` Matt Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120911180306.GI23092@atomide.com \
    --to=tony@atomide.com \
    --cc=anilkumar@ti.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mporter@ti.com \
    --cc=spi-devel-general@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.