* [PATCH] mtd: nand: omap2: fix error path
@ 2012-09-11 6:28 ` Afzal Mohammed
0 siblings, 0 replies; 5+ messages in thread
From: Afzal Mohammed @ 2012-09-11 6:28 UTC (permalink / raw)
To: dedekind1, artem.bityutskiy, linux-omap, linux-mtd; +Cc: Afzal Mohammed
Let probe return error value if gpmc terminal
count interrupt could not be obtained
Signed-off-by: Afzal Mohammed <afzal@ti.com>
---
Hi,
My commit (now in l-o/devel-gpmc),
"bd4156f mtd: nand: omap2: use gpmc provided irqs"
did not propogate error code properly due to
which this fix was required.
But this has not been mentioned in commit message
as it is not yet in mainline.
Regards
Afzal
drivers/mtd/nand/omap2.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 337cf0a..27293e3 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -1404,6 +1404,7 @@ static int __devinit omap_nand_probe(struct platform_device *pdev)
info->gpmc_irq_count = platform_get_irq(pdev, 1);
if (info->gpmc_irq_count <= 0) {
dev_err(&pdev->dev, "error getting count irq\n");
+ err = -ENODEV;
goto out_release_mem_region;
}
err = request_irq(info->gpmc_irq_count, omap_nand_irq,
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] mtd: nand: omap2: fix error path
@ 2012-09-11 6:28 ` Afzal Mohammed
0 siblings, 0 replies; 5+ messages in thread
From: Afzal Mohammed @ 2012-09-11 6:28 UTC (permalink / raw)
To: dedekind1, artem.bityutskiy, linux-omap, linux-mtd; +Cc: Afzal Mohammed
Let probe return error value if gpmc terminal
count interrupt could not be obtained
Signed-off-by: Afzal Mohammed <afzal@ti.com>
---
Hi,
My commit (now in l-o/devel-gpmc),
"bd4156f mtd: nand: omap2: use gpmc provided irqs"
did not propogate error code properly due to
which this fix was required.
But this has not been mentioned in commit message
as it is not yet in mainline.
Regards
Afzal
drivers/mtd/nand/omap2.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 337cf0a..27293e3 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -1404,6 +1404,7 @@ static int __devinit omap_nand_probe(struct platform_device *pdev)
info->gpmc_irq_count = platform_get_irq(pdev, 1);
if (info->gpmc_irq_count <= 0) {
dev_err(&pdev->dev, "error getting count irq\n");
+ err = -ENODEV;
goto out_release_mem_region;
}
err = request_irq(info->gpmc_irq_count, omap_nand_irq,
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [PATCH] mtd: nand: omap2: fix error path
2012-09-11 6:28 ` Afzal Mohammed
(?)
@ 2012-09-11 6:30 ` Mohammed, Afzal
2012-09-11 18:20 ` Tony Lindgren
-1 siblings, 1 reply; 5+ messages in thread
From: Mohammed, Afzal @ 2012-09-11 6:30 UTC (permalink / raw)
To: dedekind1@gmail.com, artem.bityutskiy@linux.intel.com,
linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org,
Tony Lindgren
+Tony
On Tue, Sep 11, 2012 at 11:58:54, Mohammed, Afzal wrote:
> Let probe return error value if gpmc terminal
> count interrupt could not be obtained
>
> Signed-off-by: Afzal Mohammed <afzal@ti.com>
> ---
> Hi,
>
> My commit (now in l-o/devel-gpmc),
>
> "bd4156f mtd: nand: omap2: use gpmc provided irqs"
>
> did not propogate error code properly due to
> which this fix was required.
>
> But this has not been mentioned in commit message
> as it is not yet in mainline.
>
> Regards
> Afzal
>
> drivers/mtd/nand/omap2.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 337cf0a..27293e3 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -1404,6 +1404,7 @@ static int __devinit omap_nand_probe(struct platform_device *pdev)
> info->gpmc_irq_count = platform_get_irq(pdev, 1);
> if (info->gpmc_irq_count <= 0) {
> dev_err(&pdev->dev, "error getting count irq\n");
> + err = -ENODEV;
> goto out_release_mem_region;
> }
> err = request_irq(info->gpmc_irq_count, omap_nand_irq,
> --
> 1.7.0.4
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mtd: nand: omap2: fix error path
2012-09-11 6:30 ` Mohammed, Afzal
@ 2012-09-11 18:20 ` Tony Lindgren
0 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2012-09-11 18:20 UTC (permalink / raw)
To: Mohammed, Afzal
Cc: artem.bityutskiy@linux.intel.com, linux-omap@vger.kernel.org,
linux-mtd@lists.infradead.org, dedekind1@gmail.com
* Mohammed, Afzal <afzal@ti.com> [120910 23:31]:
> +Tony
>
> On Tue, Sep 11, 2012 at 11:58:54, Mohammed, Afzal wrote:
> > Let probe return error value if gpmc terminal
> > count interrupt could not be obtained
Thanks I'll just fold my fix and this fix into your original
patch and push them to new devel-gpmc-fixed branch because
of the copy paste UTF-8 issues in my fix.
Regards,
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mtd: nand: omap2: fix error path
@ 2012-09-11 18:20 ` Tony Lindgren
0 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2012-09-11 18:20 UTC (permalink / raw)
To: Mohammed, Afzal
Cc: dedekind1@gmail.com, artem.bityutskiy@linux.intel.com,
linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org
* Mohammed, Afzal <afzal@ti.com> [120910 23:31]:
> +Tony
>
> On Tue, Sep 11, 2012 at 11:58:54, Mohammed, Afzal wrote:
> > Let probe return error value if gpmc terminal
> > count interrupt could not be obtained
Thanks I'll just fold my fix and this fix into your original
patch and push them to new devel-gpmc-fixed branch because
of the copy paste UTF-8 issues in my fix.
Regards,
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-09-11 18:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-11 6:28 [PATCH] mtd: nand: omap2: fix error path Afzal Mohammed
2012-09-11 6:28 ` Afzal Mohammed
2012-09-11 6:30 ` Mohammed, Afzal
2012-09-11 18:20 ` Tony Lindgren
2012-09-11 18:20 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.