From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Timur Tabi <timur@freescale.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/2] [v2] ASoC: fsl: use snd_soc_register_card to register the card
Date: Wed, 12 Sep 2012 09:32:13 +0800 [thread overview]
Message-ID: <20120912013211.GB9162@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1347380607-1564-1-git-send-email-timur@freescale.com>
On Tue, Sep 11, 2012 at 11:23:26AM -0500, Timur Tabi wrote:
> Use snd_soc_register_card() instead of platform_device_alloc("soc-audio")
> to register the sound card from the machine drivers.
>
> Although platform_device_alloc is officially deprecated, it is still used
> by several other drivers. Unfortunately, something is broken somewhere
> and the Freescale drivers don't register properly when using it. Since
> we need to transition to snd_soc_register_card() anyway, this fixes the
> problem and updates our code at the same time.
I did explain what's wrong here - it's the use of driver data.
next prev parent reply other threads:[~2012-09-12 1:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 16:23 [PATCH 1/2] [v2] ASoC: fsl: use snd_soc_register_card to register the card Timur Tabi
2012-09-11 16:23 ` [PATCH 2/2] ASoC: fsl: move machine drivers to late_initcall() Timur Tabi
2012-09-11 20:05 ` [linuxppc-release] [PATCH 1/2] [v2] ASoC: fsl: use snd_soc_register_card to register the card Timur Tabi
2012-09-12 1:32 ` Mark Brown [this message]
2012-09-12 15:12 ` Timur Tabi
2012-09-13 4:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912013211.GB9162@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.