All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [leds:for-next 18/18] drivers/leds/leds-lm3530.c:432 lm3530_probe() info: why not propagate 'err
Date: Wed, 12 Sep 2012 05:24:50 +0000	[thread overview]
Message-ID: <20120912052450.GA23490@localhost> (raw)
In-Reply-To: <20120912042018.GA22810@localhost>

> > I think the intention of the warning is that the err value from
> > lm3530_init_registers() can be directly returned, like this:
> >
> >                   err = lm3530_init_registers(drvdata);
> >                   if (err < 0) {
> >                           dev_err(&client->dev,
> >                                   "Register Init failed: %d\n", err);
> > -                         return -ENODEV;
> > +                         return err;
> >                   }
> >
> > That will remove the assumption that lm3530_init_registers() always
> > returns -ENODEV on error.
> 
> Oh OK. Now I got it :)
> Thanks for the clarification.
> Since this was a prevalent issue with this driver (and maybe with
> other driver too?), I will send a patch to fix this up.

Yes, I think so.. Thank you very much!

Thanks,
Fengguang

  parent reply	other threads:[~2012-09-12  5:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-12  4:20 [leds:for-next 18/18] drivers/leds/leds-lm3530.c:432 lm3530_probe() info: why not propagate 'err' fr Fengguang Wu
2012-09-12  4:32 ` [leds:for-next 18/18] drivers/leds/leds-lm3530.c:432 lm3530_probe() info: why not propagate 'err Fengguang Wu
2012-09-12  4:41 ` Sachin Kamat
2012-09-12  4:55 ` Fengguang Wu
2012-09-12  4:59 ` Sachin Kamat
2012-09-12  5:24 ` Fengguang Wu [this message]
2012-09-12  5:30 ` Sachin Kamat
2012-09-12  5:46 ` Bryan Wu
2012-09-12  5:52 ` Sachin Kamat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120912052450.GA23490@localhost \
    --to=fengguang.wu@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.