All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 02/11] bmp: split bmp rending in lib/bmp.c
Date: Wed, 12 Sep 2012 09:57:44 +0200	[thread overview]
Message-ID: <20120912075744.GL6180@pengutronix.de> (raw)
In-Reply-To: <1347127542-11981-2-git-send-email-plagnioj@jcrosoft.com>

In Subject: s/rending/rendering/

Or better: Move bmp rendering to lib/bmp.c

On Sat, Sep 08, 2012 at 08:05:33PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> @@ -34,3 +34,4 @@ obj-$(CONFIG_UNCOMPRESS)	+= uncompress.o
>  obj-$(CONFIG_BCH)	+= bch.o
>  obj-$(CONFIG_BITREV)	+= bitrev.o
>  obj-$(CONFIG_QSORT)	+= qsort.o
> +obj-$(CONFIG_BMP)	+= bmp.o
> diff --git a/lib/bmp.c b/lib/bmp.c
> new file mode 100644
> index 0000000..776d3b3
> --- /dev/null
> +++ b/lib/bmp.c
> @@ -0,0 +1,132 @@
> +#include <common.h>
> +#include <fs.h>
> +#include <errno.h>
> +#include <malloc.h>
> +#include <fb.h>
> +#include <bmp_layout.h>
> +#include <asm/byteorder.h>
> +
> +static inline void set_pixel(struct fb_info *info, void *adr, int r, int g, int b)

This function is first moved from commands/bmp.c to lib/bmp.c, then
added as a static inline to include/image_renderer.h, then removed again
from lib/bmp.c, then removed from include/image_renderer.h, then
reintroduced as a different function in include/graphic_utils.h.

Can you please reorder your patch series to make it readable so that we
can see what actually happens?

Thanks
 Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-09-12  7:58 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-08 18:03 [PATCH 00/11 v3] add PNG support Jean-Christophe PLAGNIOL-VILLARD
2012-09-08 18:05 ` [PATCH 01/11] bmp: rename it to splash Jean-Christophe PLAGNIOL-VILLARD
2012-09-08 18:05   ` [PATCH 02/11] bmp: split bmp rending in lib/bmp.c Jean-Christophe PLAGNIOL-VILLARD
2012-09-12  7:57     ` Sascha Hauer [this message]
2012-09-08 18:05   ` [PATCH 03/11] introduce image_renderer framework Jean-Christophe PLAGNIOL-VILLARD
2012-09-08 18:05   ` [PATCH 04/11] filetype: add BMP support Jean-Christophe PLAGNIOL-VILLARD
2012-09-08 18:05   ` [PATCH 05/11] splash/bmp: switch to image_renderer Jean-Christophe PLAGNIOL-VILLARD
2012-09-08 18:05   ` [PATCH 06/11] splash: add support to set a background color Jean-Christophe PLAGNIOL-VILLARD
2012-09-12  7:27     ` Sascha Hauer
2012-09-08 18:05   ` [PATCH 07/11] Introduce graphic utils Jean-Christophe PLAGNIOL-VILLARD
2012-09-12  7:33     ` Sascha Hauer
2012-09-08 18:05   ` [PATCH 08/11] graphic_utils: add rgba support Jean-Christophe PLAGNIOL-VILLARD
2012-09-08 18:05   ` [PATCH 09/11] filetype: add PNG support Jean-Christophe PLAGNIOL-VILLARD
2012-09-08 18:05   ` [PATCH 10/11] " Jean-Christophe PLAGNIOL-VILLARD
2012-09-12  7:37     ` Sascha Hauer
2012-09-08 18:05   ` [PATCH 11/11] png: add picoPNG lib support Jean-Christophe PLAGNIOL-VILLARD
2012-09-12  7:39     ` Sascha Hauer
2012-09-12  7:48       ` Peter Korsgaard
2012-09-12  8:01         ` Sascha Hauer
  -- strict thread matches above, loose matches on Subject: below --
2012-09-12 13:24 [PATCH 00/11 v4] add PNG support Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 13:42 ` [PATCH 01/11] bmp: rename it to splash Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 13:42   ` [PATCH 02/11] bmp: split bmp rending in lib/bmp.c Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 15:08     ` Sascha Hauer
2012-09-12 15:18       ` Jean-Christophe PLAGNIOL-VILLARD
2012-09-12 15:24         ` Sascha Hauer
2012-09-07 13:07 [PATCH 00/11 v2] add PNG support Jean-Christophe PLAGNIOL-VILLARD
2012-09-07 13:10 ` [PATCH 01/11] bmp: rename it to splash Jean-Christophe PLAGNIOL-VILLARD
2012-09-07 13:10   ` [PATCH 02/11] bmp: split bmp rending in lib/bmp.c Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120912075744.GL6180@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.