From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 3/5] ARM: bcm2708: add system timer
Date: Wed, 12 Sep 2012 10:40:32 +0000 [thread overview]
Message-ID: <201209121040.32600.arnd@arndb.de> (raw)
In-Reply-To: <1347423509-30647-3-git-send-email-swarren@wwwdotorg.org>
On Wednesday 12 September 2012, Stephen Warren wrote:
> From: Simon Arlott <simon@fire.lp0.eu>
>
> The System Timer peripheral provides four 32-bit timer channels and a
> single 64-bit free running counter. Each channel has an output compare
> register, which is compared against the 32 least significant bits of the
> free running counter values, and generates an interrupt.
>
> Timer 3 is used as the Linux timer.
>
> The BCM2708 also contains an SP804-based timer module. However, it
> apparently has significant differences from the standard SP804 IP block,
> and Broadcom's documentation recommends using the system timer instead.
>
> This patch was extracted from git://github.com/lp0/linux.git branch
> rpi-split as of 2012/09/08, and modified as follows:
>
> * Moved struct sys_timer bcm2708_timer into time.c to encapsulate it more.
> * Added DT binding docs.
> * Moved to drivers/clocksource/. This looks like the desired location for
> such code now.
> * Simplified bcm2708_time_init() to find one matching node and operate on
> it, rather than looping over all matching nodes. This seems more
> consistent with other clocksource code.
> * Renamed struct bcm2708_timer.index to match_mask to better represent its
> purpose.
> * s/printk(PR_INFO/pr_info(/
>
> Signed-off-by: Chris Boot <bootc@bootc.net>
> Signed-off-by: Simon Arlott <simon@fire.lp0.eu>
> Signed-off-by: Dom Cobley <popcornmix@gmail.com>
> Signed-off-by: Dom Cobley <dc4@broadcom.com>
> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Looks good to me, but I think the use of of_iomap() would be a good
simplification of the init function.
Arnd
next prev parent reply other threads:[~2012-09-12 10:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 4:18 [PATCH V3 1/5] ARM: add infra-structure for BCM2708/BCM2835 and Raspberry Pi Stephen Warren
2012-09-12 4:18 ` [PATCH V3 2/5] ARM: bcm2708: add interrupt controller driver Stephen Warren
2012-09-12 10:37 ` Arnd Bergmann
2012-09-13 1:12 ` Stephen Warren
2012-09-13 10:45 ` Arnd Bergmann
2012-09-14 2:21 ` Stephen Warren
2012-09-12 4:18 ` [PATCH V3 3/5] ARM: bcm2708: add system timer Stephen Warren
2012-09-12 10:40 ` Arnd Bergmann [this message]
2012-09-12 4:18 ` [PATCH V3 4/5] ARM: bcm2708: add stub clock driver Stephen Warren
2012-09-12 11:27 ` Arnd Bergmann
2012-09-12 4:18 ` [PATCH V3 5/5] ARM: bcm2708: instantiate console UART Stephen Warren
2012-09-12 10:45 ` Arnd Bergmann
2012-09-13 1:15 ` Stephen Warren
2012-09-13 10:36 ` Arnd Bergmann
2012-09-12 9:01 ` [PATCH V3 1/5] ARM: add infra-structure for BCM2708/BCM2835 and Raspberry Pi Arnd Bergmann
2012-09-13 19:51 ` Domenico Andreoli
2012-09-14 2:16 ` Stephen Warren
2012-09-16 0:34 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201209121040.32600.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.