All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] bfin: Fix warning in bfin_mac
Date: Wed, 12 Sep 2012 11:51:57 +0200	[thread overview]
Message-ID: <201209121151.57716.marex@denx.de> (raw)
In-Reply-To: <1347390507-27299-2-git-send-email-marex@denx.de>

Dear Marek Vasut,

> The buf variable in bfin_mac.c is not used and produces warning,
> fix it.
> 
> bfin_mac.c: In function 'bfin_EMAC_send':
> bfin_mac.c:125:16: warning: variable 'buf' set but not used
> [-Wunused-but-set-variable]
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Mike Frysinger <vapier@gentoo.org>

Guess I should have Cced Joe too ... 

> ---
>  drivers/net/bfin_mac.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c
> index c63398e..0ffd59d 100644
> --- a/drivers/net/bfin_mac.c
> +++ b/drivers/net/bfin_mac.c
> @@ -122,8 +122,6 @@ static int bfin_EMAC_send(struct eth_device *dev, void
> *packet, int length) {
>  	int i;
>  	int result = 0;
> -	unsigned int *buf;
> -	buf = (unsigned int *)packet;
> 
>  	if (length <= 0) {
>  		printf("Ethernet: bad packet size: %d\n", length);

Best regards,
Marek Vasut

  parent reply	other threads:[~2012-09-12  9:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-11 19:08 [U-Boot] [PATCH 1/2] bfin: Disable -fstack-usage Marek Vasut
2012-09-11 19:08 ` [U-Boot] [PATCH 2/2] bfin: Fix warning in bfin_mac Marek Vasut
2012-09-12  4:27   ` Mike Frysinger
2012-09-12  9:51   ` Marek Vasut [this message]
2012-09-12 14:32     ` Joe Hershberger
2012-09-12 16:18       ` Mike Frysinger
2012-09-12  4:27 ` [U-Boot] [PATCH 1/2] bfin: Disable -fstack-usage Mike Frysinger
2012-09-12  7:59   ` Marek Vasut
2012-09-12 17:10     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201209121151.57716.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.