From: Andrew Morton <akpm@linux-foundation.org>
To: dave@gnu.org
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
lkml <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] lib: gcd: prevent possible div by 0
Date: Wed, 12 Sep 2012 12:36:25 -0700 [thread overview]
Message-ID: <20120912123625.fd09bd60.akpm@linux-foundation.org> (raw)
In-Reply-To: <1347477630.3384.1.camel@offbook>
On Wed, 12 Sep 2012 21:20:30 +0200
Davidlohr Bueso <dave@gnu.org> wrote:
> On Wed, 2012-09-12 at 12:10 -0700, Andrew Morton wrote:
> > On Mon, 10 Sep 2012 16:35:19 +0200
> > Davidlohr Bueso <dave@gnu.org> wrote:
> >
> > > Account for all properties when a and/or b are 0:
> > > gcd(0, 0) = 0
> > > gcd(a, 0) = a
> > > gcd(0, b) = b
> > >
> > > Cc: stable@vger.kernel.org
> >
> > Why cc:stable? If this patch fixes some known problem in the current
> > kernel then that really really should have been described in the
> > changelog. Always. Please.
>
> Ok, I will keep it in mind next time. No known problem (at least that I
> know of), but due to the nature of the potential bug, I thought that it
> was worth adding it to stable.
OK.
I'm not personally averse to fixing such problems in -stable,
particualrly in lib/ code. After all, people who take -stable kernels
will then change them and add drivers and backport changes from later
kernels, etc. They might be bitten by such a bug.
I'm scratching my head a bit at the patch though. What does gcd(0, 13)
mean? That 0 can be divided by 13 zero times, which is an integer
result? I wonder why any non-buggy code would do that....
next prev parent reply other threads:[~2012-09-12 19:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 14:35 [PATCH v2] lib: gcd: prevent possible div by 0 Davidlohr Bueso
2012-09-12 19:05 ` Davidlohr Bueso
2012-09-12 19:36 ` Greg Kroah-Hartman
2012-09-12 19:10 ` Andrew Morton
2012-09-12 19:20 ` Davidlohr Bueso
2012-09-12 19:36 ` Andrew Morton [this message]
2012-09-12 20:30 ` Davidlohr Bueso
2012-09-12 21:38 ` Nick Bowler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912123625.fd09bd60.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dave@gnu.org \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.