diff for duplicates of <20120912143112.GE19694@redhat.com> diff --git a/a/1.txt b/N1/1.txt index d866b40..91d931e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -5,10 +5,10 @@ attribute. Even being safe to be this way, smatch warns about possible NULL dereference. Dan Carpenter suggested using uninitialized_var() which will make both gcc and smatch happy. -Cc: Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> -Cc: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> -Cc: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> -Signed-off-by: Aristeu Rozanski <aris-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> +Cc: Fengguang Wu <fengguang.wu@intel.com> +Cc: Tejun Heo <tj@kernel.org> +Cc: Dan Carpenter <dan.carpenter@oracle.com> +Signed-off-by: Aristeu Rozanski <aris@redhat.com> --- fs/xattr.c | 2 +- @@ -24,4 +24,4 @@ Signed-off-by: Aristeu Rozanski <aris-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> + struct simple_xattr *uninitialized_var(new_xattr); int err = 0; - /* value == NULL means remove */ + /* value = NULL means remove */ diff --git a/a/content_digest b/N1/content_digest index 46ce20c..74c0675 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,13 +1,7 @@ - "ref\020120912022813.GA17922@localhost\0" - "ref\020120912075517.GZ19396@mwanda\0" - "From\0Aristeu Rozanski <aris-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>\0" + "From\0Aristeu Rozanski <aris@redhat.com>\0" "Subject\0[PATCH] xattr: mark variable as uninitialized to make both gcc and smatch happy\0" - "Date\0Wed, 12 Sep 2012 10:31:13 -0400\0" - "To\0cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org\0" - "Cc\0Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>" - kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> - " Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>\0" + "Date\0Wed, 12 Sep 2012 14:31:13 +0000\0" + "To\0kernel-janitors@vger.kernel.org\0" "\00:1\0" "b\0" "new_xattr in __simple_xattr_set() is only initialized with a valid\n" @@ -17,10 +11,10 @@ "NULL dereference. Dan Carpenter suggested using uninitialized_var()\n" "which will make both gcc and smatch happy.\n" "\n" - "Cc: Fengguang Wu <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>\n" - "Cc: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>\n" - "Cc: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>\n" - "Signed-off-by: Aristeu Rozanski <aris-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>\n" + "Cc: Fengguang Wu <fengguang.wu@intel.com>\n" + "Cc: Tejun Heo <tj@kernel.org>\n" + "Cc: Dan Carpenter <dan.carpenter@oracle.com>\n" + "Signed-off-by: Aristeu Rozanski <aris@redhat.com>\n" "\n" "---\n" " fs/xattr.c | 2 +-\n" @@ -36,6 +30,6 @@ "+\tstruct simple_xattr *uninitialized_var(new_xattr);\n" " \tint err = 0;\n" " \n" - " \t/* value == NULL means remove */" + " \t/* value = NULL means remove */" -05fc8d8b7b565768d6690fc0e047f13fd008200138b7d5f1c5cbdf588a92da27 +732b7294a29aaaac54de576241a7b513fa89d73bfcb827e89c0f515a7b5b2452
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.