From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Nieder Subject: Re: [PATCH] drm/i915: Wait for all pending operations to the fb before disabling the pipe Date: Wed, 12 Sep 2012 08:09:33 -0700 Message-ID: <20120912150933.GA676@mannheim-rule.local> References: <1347461831-18546-1-git-send-email-timo.aaltonen@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pz0-f49.google.com (mail-pz0-f49.google.com [209.85.210.49]) by gabe.freedesktop.org (Postfix) with ESMTP id ED2949EEBA for ; Wed, 12 Sep 2012 08:08:10 -0700 (PDT) Received: by dajq27 with SMTP id q27so1118831daj.36 for ; Wed, 12 Sep 2012 08:08:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1347461831-18546-1-git-send-email-timo.aaltonen@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Timo Aaltonen Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org Hi Timo, Timo Aaltonen wrote: > commit d698c826bb93663e4b349a78fbd30443654d37cd upstream. > > Please pull this for v3.2.x, should be the last missing (kernel) piece > for https://bugs.freedesktop.org/show_bug.cgi?id=48838 [...] > It should be more reliable to wait for the pending > operations to complete first, even though we still have a window for > userspace to submit a broken command buffer during the modeset. That sounds hazy --- is it tested? Presumably this is needed for 3.4.y and 3.5.y as well, right? Do you know when the bad behavior was introduced? Does 3.0.y need the fix as well? Thanks and hope that helps, Jonathan