From: Cyrill Gorcunov <gorcunov@openvz.org>
To: Asias He <asias.hejun@gmail.com>
Cc: Pekka Enberg <penberg@kernel.org>,
Sasha Levin <levinsasha928@gmail.com>,
Ingo Molnar <mingo@elte.hu>,
kvm@vger.kernel.org
Subject: Re: [PATCH 2/2] kvm tools: Bring SMP back
Date: Wed, 12 Sep 2012 19:10:05 +0400 [thread overview]
Message-ID: <20120912151005.GR15042@moon> (raw)
In-Reply-To: <1347462216-18641-2-git-send-email-asias.hejun@gmail.com>
On Wed, Sep 12, 2012 at 11:03:36PM +0800, Asias He wrote:
> We have this currently:
>
> kvm__init()
> kvm__arch_setup_firmware()
> mptable__init()
> using kvm->nrcpus
>
> kvm_cpu__init()
> kvm->nrcpus = kvm->cfg.nrcpus
>
> kvm->nrcpus is used in mptable__init() before it is initialized, so
> mptable__init() will setup a wrong mp table.
>
> Before:
> $ ./lkvm -c 4
> $ cat /proc/cpuinfo |grep ^processor|wc -l
> 1
>
> After:
> $ ./lkvm -c 4
> $ cat /proc/cpuinfo |grep ^processor|wc -l
> 4
>
> Signed-off-by: Asias He <asias.hejun@gmail.com>
Good catch!
prev parent reply other threads:[~2012-09-12 15:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 15:03 [PATCH 1/2] kvm tools: Move -O2 back to CFLAGS Asias He
2012-09-12 15:03 ` [PATCH 2/2] kvm tools: Bring SMP back Asias He
2012-09-12 15:10 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912151005.GR15042@moon \
--to=gorcunov@openvz.org \
--cc=asias.hejun@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.