From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Nieder Subject: Re: [PATCH] drm/i915: Wait for all pending operations to the fb before disabling the pipe Date: Wed, 12 Sep 2012 09:03:03 -0700 Message-ID: <20120912160303.GC676@mannheim-rule.local> References: <1347461831-18546-1-git-send-email-timo.aaltonen@canonical.com> <20120912150933.GA676@mannheim-rule.local> <5050A903.2000403@ubuntu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pb0-f49.google.com (mail-pb0-f49.google.com [209.85.160.49]) by gabe.freedesktop.org (Postfix) with ESMTP id DF03D9E762 for ; Wed, 12 Sep 2012 09:01:37 -0700 (PDT) Received: by pbbrq8 with SMTP id rq8so2651422pbb.36 for ; Wed, 12 Sep 2012 09:01:37 -0700 (PDT) Content-Disposition: inline In-Reply-To: <5050A903.2000403@ubuntu.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Timo Aaltonen Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org Timo Aaltonen wrote: > Well, these are usually hard to verify fixed. The commit is mentioned on > fdo bugs 45413 and 48838, should fix some GPU hangs. The stable kernel rules are very clear about this: - It must be obviously correct and tested. Please ensure the backport gets tested on a machine that was affected by the problem. That doesn't mean we need 100% confidence that the fix worked, but if I understand you correctly it is possible that nobody tested the backport on real hardware at all. An ack from someone on the i915 team would be welcome as well. Thanks and hope that helps, Jonathan