From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Nieder Subject: Re: [PATCH] drm/i915: Wait for all pending operations to the fb before disabling the pipe Date: Wed, 12 Sep 2012 09:24:16 -0700 Message-ID: <20120912162416.GA877@mannheim-rule.local> References: <1347461831-18546-1-git-send-email-timo.aaltonen@canonical.com> <20120912150933.GA676@mannheim-rule.local> <5050A903.2000403@ubuntu.com> <20120912160303.GC676@mannheim-rule.local> <20120912161450.GS5533@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pb0-f49.google.com (mail-pb0-f49.google.com [209.85.160.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 1CCE49E7D3 for ; Wed, 12 Sep 2012 09:22:53 -0700 (PDT) Received: by pbbrq8 with SMTP id rq8so2681906pbb.36 for ; Wed, 12 Sep 2012 09:22:52 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20120912161450.GS5533@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org Daniel Vetter wrote: > On Wed, Sep 12, 2012 at 09:03:03AM -0700, Jonathan Nieder wrote: >> An ack from someone on the i915 team would be welcome as well. > > It's the right thing. The comment about "hough we still have a window for > userspace to submit a broken command buffer during the modeset" just > re-stresses that client can still kill the gpu. But with this fix here > userspace has at least a chance to get it right, whereas before it just > fell over sometimes. Thanks for the quick and clear feedback. Makes sense. Jonathan