All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Bruce Humphrey <brucehum@gmail.com>
Cc: abbotti@mev.co.uk, fmhess@users.sourceforge.net,
	gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Staging: comedi: fl512: Replace printk with dev_info et al
Date: Thu, 13 Sep 2012 11:03:09 +0300	[thread overview]
Message-ID: <20120913080309.GJ19396@mwanda> (raw)
In-Reply-To: <1347500796-4432-1-git-send-email-brucehum@gmail.com>

On Thu, Sep 13, 2012 at 03:46:36AM +0200, Bruce Humphrey wrote:
> Replace printk(KERN_XXX with the appropiate dev_info, dev_warn, dev_dbg in fl512.c
> 
> Signed-off-by: Bruce Humphrey Ventura <brucehum@gmail.com>
> ---
>  drivers/staging/comedi/drivers/fl512.c |   12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/fl512.c b/drivers/staging/comedi/drivers/fl512.c
> index d1da809..5a8e0ae 100644
> --- a/drivers/staging/comedi/drivers/fl512.c
> +++ b/drivers/staging/comedi/drivers/fl512.c
> @@ -118,9 +118,9 @@ static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>  	struct comedi_subdevice *s;
>  
>  	iobase = it->options[0];
> -	printk(KERN_INFO "comedi:%d fl512: 0x%04lx", dev->minor, iobase);
> +	dev_info(dev->class_dev, "%s: 0x%04lx\n", dev->board_name, iobase);

Only print this at the end when it succeeds.

>  	if (!request_region(iobase, FL512_SIZE, "fl512")) {
> -		printk(KERN_WARNING " I/O port conflict\n");
> +		dev_warn(dev->class_dev, " I/O port conflict\n");
                                          ^
Bogus space.

>  		return -EIO;
>  	}
>  	dev->iobase = iobase;
> @@ -129,7 +129,7 @@ static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>  		return -ENOMEM;
>  
>  #if DEBUG
> -	printk(KERN_DEBUG "malloc ok\n");
> +	dev_dbg(dev->class_dev, "malloc ok\n");
>  #endif

Remove this section.

>  
>  	ret = comedi_alloc_subdevices(dev, 2);
> @@ -153,7 +153,8 @@ static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>  	s->range_table = &range_fl512;
>  	/* function to call when read AD */
>  	s->insn_read = fl512_ai_insn;
> -	printk(KERN_INFO "comedi: fl512: subdevice 0 initialized\n");
> +	dev_info(dev->class_dev, "%s: subdevice 0 initialized\n",
> +		dev->board_name);

Delete.

>  
>  	/* Analog output */
>  	s = dev->subdevices + 1;
> @@ -171,7 +172,8 @@ static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>  	s->insn_write = fl512_ao_insn;
>  	/* function to call when reading DA */
>  	s->insn_read = fl512_ao_insn_readback;
> -	printk(KERN_INFO "comedi: fl512: subdevice 1 initialized\n");
> +	dev_info(dev->class_dev, "%s: subdevice 1 initialized\n",
> +		dev->board_name);

Move the print from the start down to here.  Re-word it.  Copy from
one that Hartley has worked on.

regards,
dan carpenter

>  
>  	return 1;
>  }
> -- 
> 1.7.9.5
> 
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

      reply	other threads:[~2012-09-13  8:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-13  1:46 [PATCH 2/2] Staging: comedi: fl512: Replace printk with dev_info et al Bruce Humphrey
2012-09-13  8:03 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120913080309.GJ19396@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=abbotti@mev.co.uk \
    --cc=brucehum@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=fmhess@users.sourceforge.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.