From: Dan Carpenter <dan.carpenter@oracle.com>
To: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Jens Taprogge <jens.taprogge@taprogge.org>,
linux-kernel@vger.kernel.org,
industrypack-devel@lists.sourceforge.net
Subject: Re: [PATCH 3/5] staging: ipack: remove irq field in struct ipack_device.
Date: Thu, 13 Sep 2012 13:01:45 +0300 [thread overview]
Message-ID: <20120913100145.GL19396@mwanda> (raw)
In-Reply-To: <1347529588-21212-3-git-send-email-siglesias@igalia.com>
On Thu, Sep 13, 2012 at 11:46:26AM +0200, Samuel Iglesias Gonsalvez wrote:
> From: Jens Taprogge <jens.taprogge@taprogge.org>
>
> The field irq currently is identical to the slot number. It does not seem to
> have any real use. The number is written to hardware in ipoctal but it seems
> the value that is written does not matter.
>
> Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org>
> Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
> ---
> - iowrite8(vector, ipoctal->dev->mem_space.address + 1);
> + iowrite8(1, ipoctal->dev->mem_space.address + 1);
It might be nice to put a /* dummy write */ comment here.
regards,
dan carpenter
next prev parent reply other threads:[~2012-09-13 10:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 9:46 [PATCH 1/5] Staging: ipack: Add IPACK_INT_SPACE memory space Samuel Iglesias Gonsalvez
2012-09-13 9:46 ` [PATCH 2/5] Staging: ipack: move the responsibility to clear interrupts to the IPack devices Samuel Iglesias Gonsalvez
2012-09-13 9:46 ` [PATCH 3/5] staging: ipack: remove irq field in struct ipack_device Samuel Iglesias Gonsalvez
2012-09-13 10:01 ` Dan Carpenter [this message]
2012-09-13 10:33 ` Samuel Iglesias Gonsálvez
2012-09-13 9:46 ` [PATCH 4/5] Staging: ipack/devices/ipoctal: acknowledge BREAK condition Samuel Iglesias Gonsalvez
2012-09-13 10:02 ` Dan Carpenter
2012-09-13 10:07 ` Samuel Iglesias Gonsálvez
2012-09-13 9:46 ` [PATCH 5/5] Staging: ipack/devices/ipoctal: simplify ipoctal_write_tty() Samuel Iglesias Gonsalvez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120913100145.GL19396@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=industrypack-devel@lists.sourceforge.net \
--cc=jens.taprogge@taprogge.org \
--cc=linux-kernel@vger.kernel.org \
--cc=siglesias@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.