Re: [PATCH] drm/nouveau: add default debug level override

[Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

On Thu, Sep 13, 2012 at 12:09:20PM +1000, Ben Skeggs wrote:
> On Thu, Sep 13, 2012 at 12:50:06AM +0200, Marcin Slusarz wrote:
> > Useful when we don't know which subsystem is failing.
> This is really unnecessary unless I'm missing something.  You can pass nouveau.debug=LEVEL (without specifying a subdev name) to set the default already.

Does not work for me: http://bpaste.net/show/45252/
(ignore gpio debugging messages - I'm looking for suspend regression)

> > 
> > Signed-off-by: Marcin Slusarz <marcin.slusarz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > ---
> >  drivers/gpu/drm/nouveau/core/core/option.c | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/nouveau/core/core/option.c b/drivers/gpu/drm/nouveau/core/core/option.c
> > index 62a432e..fde06b0 100644
> > --- a/drivers/gpu/drm/nouveau/core/core/option.c
> > +++ b/drivers/gpu/drm/nouveau/core/core/option.c
> > @@ -22,9 +22,16 @@
> >   * Authors: Ben Skeggs
> >   */
> >  
> > +#include <linux/module.h>
> >  #include <core/option.h>
> >  #include <core/debug.h>
> >  
> > +MODULE_PARM_DESC(debug_level, "nv_printk level (0-"
> > +		__stringify(CONFIG_NOUVEAU_DEBUG) ", default "
> > +		__stringify(CONFIG_NOUVEAU_DEBUG_DEFAULT) ")");
> > +static int nouveau_debug_level = CONFIG_NOUVEAU_DEBUG_DEFAULT;
> > +module_param_named(debug_level, nouveau_debug_level, int, 0400);
> > +
> >  /* compares unterminated string 'str' with zero-terminated string 'cmp' */
> >  static inline int
> >  strncasecmpz(const char *str, const char *cmp, size_t len)
> > @@ -86,7 +93,7 @@ nouveau_boolopt(const char *optstr, const char *opt, bool value)
> >  int
> >  nouveau_dbgopt(const char *optstr, const char *sub)
> >  {
> > -	int mode = 1, level = CONFIG_NOUVEAU_DEBUG_DEFAULT;
> > +	int mode = 1, level = nouveau_debug_level;
> >  
> >  	while (optstr) {
> >  		int len = strcspn(optstr, ",=");
> > -- 
> > 1.7.12
> >