All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4 v3] xilinx: Add new Zynq board
Date: Thu, 13 Sep 2012 11:35:08 +0200	[thread overview]
Message-ID: <201209131135.08970.marex@denx.de> (raw)
In-Reply-To: <1345098630-27902-4-git-send-email-monstr@monstr.eu>

Dear Michal Simek,

[...]

> +int board_init(void)
> +{
> +	icache_enable();

Uh oh ... isn't this on by default when CONFIG_ICACHE_OFF isn't present?

> +	return 0;
> +}
> +
> +int board_late_init(void)
> +{
> +	return 0;

You don't need this.

> +}
> +
> +#ifdef CONFIG_CMD_NET
> +int board_eth_init(bd_t *bis)
> +{
> +	int ret = 0;
> +
> +#if defined(CONFIG_ZYNQ_GEM) && defined(CONFIG_ZYNQ_GEM_BASEADDR0)
> +	ret |= zynq_gem_initialize(bis, CONFIG_ZYNQ_GEM_BASEADDR0);

ret |= ? ;-)

> +#endif
> +
> +	return ret;
> +}
> +#endif
> +
> +int dram_init(void)
> +{
> +	gd->ram_size = CONFIG_SYS_SDRAM_SIZE;
> +	return 0;
> +}
> +
> +void reset_cpu(ulong addr)
> +{
> +	while (1)
> +		;
> +}

This is definitelly CPU specific.
[...]

  parent reply	other threads:[~2012-09-13  9:35 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-16  6:30 [U-Boot] [PATCH 1/4 v2] serial: Add Zynq serial driver Michal Simek
2012-08-16  6:30 ` [U-Boot] [PATCH 2/4 v2] net: Add driver for Zynq Gem IP Michal Simek
2012-09-12 10:19   ` Michal Simek
2012-09-13  9:28   ` Marek Vasut
2012-09-13 10:16     ` Michal Simek
2012-09-13 12:30       ` Marek Vasut
2012-09-14  3:49     ` Joe Hershberger
2012-09-14  4:45       ` Marek Vasut
     [not found]         ` <CANr=Z=aejhXoGabpcderroSeQSWJM+cbXS7yg6NVeHKJLqQhRQ@mail.gmail.com>
2012-09-14  7:34           ` Marek Vasut
2012-08-16  6:30 ` [U-Boot] [PATCH 3/4 v2] arm: Support new Xilinx Zynq platform Michal Simek
2012-09-12 10:23   ` Michal Simek
2012-09-13  9:32     ` Marek Vasut
2012-09-13  9:36       ` Michal Simek
2012-09-13  9:31   ` Marek Vasut
2012-09-13  9:52     ` Michal Simek
2012-09-13 10:31       ` Marek Vasut
2012-09-13 11:24         ` Michal Simek
2012-09-13 12:32           ` Marek Vasut
2012-09-13 12:52             ` Michal Simek
2012-09-13 13:01               ` Marek Vasut
2012-08-16  6:30 ` [U-Boot] [PATCH 4/4 v3] xilinx: Add new Zynq board Michal Simek
2012-09-12 10:23   ` Michal Simek
2012-09-13  9:35   ` Marek Vasut [this message]
2012-09-13  9:55     ` Michal Simek
2012-09-13 12:31       ` Marek Vasut
2012-09-13 12:17     ` Michal Simek
2012-09-14  4:03   ` Joe Hershberger
2012-09-14  5:42     ` Michal Simek
2012-09-12 10:20 ` [U-Boot] [PATCH 1/4 v2] serial: Add Zynq serial driver Michal Simek
2012-09-13  9:21 ` Marek Vasut
2012-09-13  9:45   ` Michal Simek
2012-09-13 12:33     ` Marek Vasut
2012-09-13 13:54       ` Michal Simek
2012-09-13 14:01         ` Marek Vasut
2012-09-14  4:09           ` Joe Hershberger
2012-09-14  4:47             ` Marek Vasut
2012-09-14  5:23               ` Joe Hershberger
2012-09-14  7:39                 ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201209131135.08970.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.