From: Fengguang Wu <fengguang.wu@intel.com>
To: kernel-janitors@vger.kernel.org
Subject: [digsig:working 47/64] security/integrity/digsig.c:74:1: warning: 'shash_digest' uses dynamic stack
Date: Thu, 13 Sep 2012 14:48:07 +0000 [thread overview]
Message-ID: <20120913144807.GA2562@localhost> (raw)
Hi Dmitry,
I'm not sure if the warned 'dynamic stack allocation' is relevant, but
as an FYI:
tree: git://git.kernel.org/pub/scm/linux/kernel/git/kasatkin/linux-digsig.git working
head: ca88a6aa648a167b6f8e5666518249635510b0b0
commit: c6a28f9ee92fe96c5a7c4e5989eb7ae06b545469 [47/64] integrity: added digest calculation function
config: s390-allyesconfig
All error/warnings:
security/integrity/digsig.c: In function 'shash_digest':
security/integrity/digsig.c:74:1: warning: 'shash_digest' uses dynamic stack allocation [enabled by default]
vim +74 security/integrity/digsig.c
64 char ctx[crypto_shash_descsize(tfm)];
65 } desc;
66
67 desc.shash.tfm = tfm;
68 desc.shash.flags = 0;
69
70 rc = crypto_shash_digest(&desc.shash, data, len, digest);
71 if (!rc)
72 rc = crypto_shash_digestsize(tfm);
73 return rc;
> 74 }
75
76 /**
77 * integrity_calc_digest() - digest calculation
78 * @algo: digest algo id (enum digest_algo)
79 * @data: data
80 * @len: length of the data
81 * @digest: digest
82 * @return: digest length on success, -EINVAL otherwise
83 *
84 * Calculates digest of the data.
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com> Intel Corporation
next reply other threads:[~2012-09-13 14:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 14:48 Fengguang Wu [this message]
2012-09-13 14:49 ` [digsig:working 47/64] security/integrity/digsig.c:74:1: warning: 'shash_digest' uses dynamic st Kasatkin, Dmitry
2012-09-13 15:10 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120913144807.GA2562@localhost \
--to=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.