From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH REPOST RFC cgroup/for-3.7] cgroup: mark subsystems with broken hierarchy support and whine if cgroups are nested for them Date: Thu, 13 Sep 2012 10:21:37 -0700 Message-ID: <20120913172137.GZ7677@google.com> References: <20120910223125.GC7677@google.com> <20120910223355.GD7677@google.com> <20120911100433.GC8058@dhcp22.suse.cz> <5050568B.9090601@parallels.com> <20120912154907.GW21579@dhcp22.suse.cz> <20120912171120.GP7677@google.com> <5051CB24.4010801@parallels.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=4jeS31heSxc1C/7+gg0UcbNasT9MI3Q6h3D1hyhsNw4=; b=qtgQZaSQ0ms+RrbHsp9yROZVoHV7cjaLvpZo6HmZB1mR16yMJe4df6MSGqHUg+5/SD Gr68G/b0wgld3Zl8VM4OG0p4hmMAih+C0neG0tgcJ0csmmp6kt85Z2jqQtAEJ3Dh50vl TI70ZQZZ0mwcO4J/YsKK8AKYn2utQXKYr+MMYkiMbbGyzfdueuaMMd33fbXbZ8XhkmAh 66P2Lwg8o4ziMTSNpNctpQGf/+O9lBmwXT6TRKhnmq7YrEQO2qJdVFE2anCwzMRJwV6x tKF8jlO5V0QWjDVWR+M1DK8Cj4ZrSLtwW74/BDbUijTOKFO8daDOTjdVuvhAgrJAalT6 fqTA== Content-Disposition: inline In-Reply-To: <5051CB24.4010801-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Glauber Costa Cc: Neil Horman , "Serge E. Hallyn" , containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Michal Hocko , Paul Mackerras , "Aneesh Kumar K.V" , Arnaldo Carvalho de Melo , Johannes Weiner , Thomas Graf , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Paul Turner , Ingo Molnar , Vivek Goyal Hello, Glauber. On Thu, Sep 13, 2012 at 04:01:40PM +0400, Glauber Costa wrote: > This is getting confusing for me as well, because I don't know if your > reply was targeted towards me or Michal. As for me, I am in agreement > with what you did, and I merely replied to Michal's concern and > suggestion of not warning in the special 1-st level only setups saying I > side with you. Oh, I was replying to Michal. I thought there was behavior difference with the .use_hierarchy=0 cases that Michal was talking about but I don't think that's the case and Michal is trying to say that we shouldn't warn if the configuration behaves identical to root.use_hierarchy=1 even if it contains some .use_hierarchy=0's, which I'm fine with. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932292Ab2IMRVp (ORCPT ); Thu, 13 Sep 2012 13:21:45 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:48600 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755009Ab2IMRVm (ORCPT ); Thu, 13 Sep 2012 13:21:42 -0400 Date: Thu, 13 Sep 2012 10:21:37 -0700 From: Tejun Heo To: Glauber Costa Cc: Michal Hocko , linux-kernel@vger.kernel.org, containers@lists.linux-foundation.org, cgroups@vger.kernel.org, Li Zefan , Peter Zijlstra , Paul Turner , Johannes Weiner , Thomas Graf , "Serge E. Hallyn" , Vivek Goyal , Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo , Neil Horman , "Aneesh Kumar K.V" Subject: Re: [PATCH REPOST RFC cgroup/for-3.7] cgroup: mark subsystems with broken hierarchy support and whine if cgroups are nested for them Message-ID: <20120913172137.GZ7677@google.com> References: <20120910223125.GC7677@google.com> <20120910223355.GD7677@google.com> <20120911100433.GC8058@dhcp22.suse.cz> <5050568B.9090601@parallels.com> <20120912154907.GW21579@dhcp22.suse.cz> <20120912171120.GP7677@google.com> <5051CB24.4010801@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5051CB24.4010801@parallels.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Glauber. On Thu, Sep 13, 2012 at 04:01:40PM +0400, Glauber Costa wrote: > This is getting confusing for me as well, because I don't know if your > reply was targeted towards me or Michal. As for me, I am in agreement > with what you did, and I merely replied to Michal's concern and > suggestion of not warning in the special 1-st level only setups saying I > side with you. Oh, I was replying to Michal. I thought there was behavior difference with the .use_hierarchy=0 cases that Michal was talking about but I don't think that's the case and Michal is trying to say that we shouldn't warn if the configuration behaves identical to root.use_hierarchy=1 even if it contains some .use_hierarchy=0's, which I'm fine with. Thanks. -- tejun