All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Glauber Costa <glommer@parallels.com>
Cc: linux-kernel@vger.kernel.org, Michal Hocko <mhocko@suse.cz>,
	Li Zefan <lizf@cn.fujitsu.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Paul Turner <pjt@google.com>,
	Johannes Weiner <hannes@cmpxchg.org>, Thomas Graf <tgraf@suug.ch>,
	"Serge E. Hallyn" <serue@us.ibm.com>,
	Vivek Goyal <vgoyal@redhat.com>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Neil Horman <nhorman@tuxdriver.com>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	Dave Jones <davej@redhat.com>,
	Lennart Poettering <lennart@poettering.net>,
	Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [PATCH RFC cgroup/for-3.7] cgroup: mark subsystems with broken hierarchy support and whine if cgroups are nested for them
Date: Thu, 13 Sep 2012 10:48:17 -0700	[thread overview]
Message-ID: <20120913174817.GA7677@google.com> (raw)
In-Reply-To: <5051C954.2080600@parallels.com>

Hello, Glauber.

On Thu, Sep 13, 2012 at 03:53:56PM +0400, Glauber Costa wrote:
> Here is where the Kconfig option comes to play. If we do it in the
> kernel, userspace doesn't have to do anything. I spoke with Lennart and
> Kay, and at least from a systemd PoV, they would much rather not provide
> a hack in userspace for a file that is scheduled to go away in any case
> - which I personally believe is a fair request.
> 
> It is a default, so the effect for the user is the same: After the
> machine boots, use_hierarchy = 1, and he can still flip to 0 for some time.

Alright, let's go Kconfig.  Let's just make sure that the transitional
nature is clearly labeled and the fact that the default config will
generate a warning when nested cgroups are created in memcg.  We can
then coordinate the flip with distros.  Can you please repost the
Kconfig patch?

> > Setting mark on a parent should be reflected on all its children w/o
> > their own explicit settings.
> 
> That is clear, and better behavior than we have today. What I mean, is
> that by setting its own marking, the child can pretty much "escape" the
> group.
> 
> The ideal solution - from this point of view only - would be to have
> more than one marking, and mark with all the way down to the root. So if
> you have an iptables rule to match one marking, it still applies to the
> kids. And you can still have extra markings.
> 
> I am not sure this is feasible, though, in which case your solution
> could be a good compromise. But please let's aim for it.

I don't think it supports multiple tags.  If that's possible, it would
be nice but I don't think it's a must.

Thanks.

-- 
tejun

  parent reply	other threads:[~2012-09-13 17:48 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-10 22:31 [PATCH RFC cgroup/for-3.7] cgroup: mark subsystems with broken hierarchy support and whine if cgroups are nested for them Tejun Heo
     [not found] ` <20120910223125.GC7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-10 22:33   ` [PATCH REPOST " Tejun Heo
2012-09-10 22:33     ` Tejun Heo
     [not found]     ` <20120910223355.GD7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-11 10:04       ` Michal Hocko
2012-09-11 10:04         ` Michal Hocko
     [not found]         ` <20120911100433.GC8058-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-09-11 17:07           ` Tejun Heo
2012-09-11 17:07           ` Tejun Heo
2012-09-11 17:07             ` Tejun Heo
     [not found]             ` <20120911170746.GL7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-12 15:47               ` Michal Hocko
2012-09-12 15:47                 ` Michal Hocko
     [not found]                 ` <20120912154745.GV21579-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-09-12 16:41                   ` Tejun Heo
2012-09-12 16:41                     ` Tejun Heo
2012-09-12 15:47               ` Michal Hocko
2012-09-12  9:31           ` Glauber Costa
     [not found]             ` <5050568B.9090601-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-12 15:49               ` Michal Hocko
2012-09-12 15:49                 ` Michal Hocko
     [not found]                 ` <20120912154907.GW21579-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-09-12 17:11                   ` Tejun Heo
2012-09-12 17:11                     ` Tejun Heo
     [not found]                     ` <20120912171120.GP7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-13 12:01                       ` Glauber Costa
     [not found]                         ` <5051CB24.4010801-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-13 17:21                           ` Tejun Heo
2012-09-13 17:21                             ` Tejun Heo
2012-09-13 12:14                       ` Michal Hocko
2012-09-13 12:14                         ` Michal Hocko
     [not found]                         ` <20120913121438.GC8055-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-09-13 17:18                           ` Tejun Heo
2012-09-13 17:18                             ` Tejun Heo
     [not found]                             ` <20120913171832.GY7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-13 17:39                               ` Michal Hocko
2012-09-13 17:39                                 ` Michal Hocko
     [not found]                                 ` <20120913173958.GA21381-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org>
2012-09-14  8:19                                   ` Glauber Costa
     [not found]                                     ` <5052E87A.1050405-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-14 19:15                                       ` Tejun Heo
2012-09-14 19:15                                         ` Tejun Heo
     [not found]                                         ` <20120914191509.GN17747-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-17  9:11                                           ` Glauber Costa
2012-09-11 12:38       ` Li Zefan
2012-09-11 12:38         ` Li Zefan
     [not found]         ` <504F30DB.60808-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2012-09-11 17:08           ` Tejun Heo
2012-09-11 17:08             ` Tejun Heo
     [not found]             ` <20120911170837.GM7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-11 17:43               ` Tejun Heo
2012-09-11 17:43                 ` Tejun Heo
     [not found]                 ` <20120911174319.GO7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-12  9:37                   ` Glauber Costa
     [not found]                     ` <505057D8.4010908-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-09-12 16:34                       ` Tejun Heo
2012-09-12 16:34                         ` Tejun Heo
     [not found]                         ` <20120912163433.GL7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-13  6:48                           ` Li Zefan
2012-09-13  6:48                             ` Li Zefan
2012-09-11 17:08           ` Tejun Heo
2012-09-12  9:34           ` Glauber Costa
2012-09-11 12:38       ` Li Zefan
2012-09-11 18:23       ` [PATCH UPDATED " Tejun Heo
2012-09-11 18:23       ` Tejun Heo
2012-09-11 18:23         ` Tejun Heo
     [not found]         ` <20120911182356.GR7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-11 20:50           ` Aristeu Rozanski
2012-09-11 20:50             ` Aristeu Rozanski
     [not found]             ` <20120911205027.GA25837-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-11 20:51               ` Tejun Heo
2012-09-11 20:51                 ` Tejun Heo
2012-09-11 20:51               ` Tejun Heo
2012-09-13 12:16       ` [PATCH REPOST " Daniel P. Berrange
2012-09-13 12:16         ` Daniel P. Berrange
     [not found]         ` <20120913121629.GL7767-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-09-13 17:52           ` Tejun Heo
2012-09-13 17:52           ` Tejun Heo
2012-09-13 17:52             ` Tejun Heo
2012-09-10 22:33   ` Tejun Heo
2012-09-11 14:51 ` [PATCH " Vivek Goyal
2012-09-11 14:54   ` Vivek Goyal
2012-09-11 17:16   ` Tejun Heo
2012-09-11 17:35     ` Vivek Goyal
2012-09-11 17:55       ` Tejun Heo
2012-09-11 18:16         ` Vivek Goyal
2012-09-11 18:22           ` Tejun Heo
2012-09-11 18:38             ` Vivek Goyal
     [not found]         ` <50505C39.1050600@parallels.com>
2012-09-12 17:09           ` Tejun Heo
2012-09-13 14:53             ` Block IO controller hierarchy suppport (Was: Re: [PATCH RFC cgroup/for-3.7] cgroup: mark subsystems with broken hierarchy support and whine if cgroups are nested for them) Vivek Goyal
2012-09-13 22:06               ` Tejun Heo
2012-09-14  2:53                 ` Vivek Goyal
     [not found]                   ` <5052E8DA.1000106@parallels.com>
2012-09-14 13:22                     ` Vivek Goyal
     [not found]             ` <5051CBAA.5040308@parallels.com>
2012-09-13 17:54               ` [PATCH RFC cgroup/for-3.7] cgroup: mark subsystems with broken hierarchy support and whine if cgroups are nested for them Tejun Heo
     [not found]                 ` <5052E931.8000007@parallels.com>
2012-09-14 18:56                   ` Tejun Heo
     [not found] ` <505055E5.90903@parallels.com>
2012-09-12 17:03   ` Tejun Heo
     [not found]     ` <5051C954.2080600@parallels.com>
2012-09-13 17:48       ` Tejun Heo [this message]
     [not found]         ` <5052E9BC.2020908@parallels.com>
2012-09-17  7:59           ` Daniel Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120913174817.GA7677@google.com \
    --to=tj@kernel.org \
    --cc=acme@ghostprotocols.net \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=davej@redhat.com \
    --cc=glommer@parallels.com \
    --cc=hannes@cmpxchg.org \
    --cc=kay.sievers@vrfy.org \
    --cc=lennart@poettering.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=mhocko@suse.cz \
    --cc=mingo@redhat.com \
    --cc=nhorman@tuxdriver.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=serue@us.ibm.com \
    --cc=tgraf@suug.ch \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.