From mboxrd@z Thu Jan 1 00:00:00 1970 From: Seth Forshee Subject: Re: [PATCH] gmux: Fix backlight set function Date: Thu, 13 Sep 2012 15:26:14 -0500 Message-ID: <20120913202614.GA26996@thinkpad-t410> References: <1347566555-9388-1-git-send-email-grant.likely@secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from youngberry.canonical.com ([91.189.89.112]:48622 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932174Ab2IMU0S (ORCPT ); Thu, 13 Sep 2012 16:26:18 -0400 Content-Disposition: inline In-Reply-To: <1347566555-9388-1-git-send-email-grant.likely@secretlab.ca> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Grant Likely Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Matthew Garrett On Thu, Sep 13, 2012 at 09:02:35PM +0100, Grant Likely wrote: > In commit 7e30ed6b, "gmux: Add generic write32 function", the new > gmux_write32() function didn't include the io offset when writing > registers. This means that backlight update writes never go to the right > place. This patch fixes it. > > Tested on Apple Macbook 8,3 > > Signed-off-by: Grant Likely > Cc: Matthew Garrett I sent a patch for this several weeks ago [1], just waiting for Matthew to pick it up. Seth [1] https://lkml.org/lkml/2012/8/21/721