From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] i915: initialize CADL in opregion Date: Thu, 13 Sep 2012 23:17:57 +0200 Message-ID: <20120913211757.GI5693@phenom.ffwll.local> References: <1574631.uSlQXEJRId@al> <20120626140400.2cdb1f3f@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 1BDDB9E7D1 for ; Thu, 13 Sep 2012 14:17:22 -0700 (PDT) Received: by weyr3 with SMTP id r3so2043052wey.36 for ; Thu, 13 Sep 2012 14:17:22 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20120626140400.2cdb1f3f@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: Lekensteyn , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Tue, Jun 26, 2012 at 02:04:00PM -0700, Jesse Barnes wrote: > On Tue, 26 Jun 2012 00:36:24 +0200 > Lekensteyn wrote: > > > This is rather a hack to fix brightness hotkeys on a Clevo laptop. CADL is not > > used anywhere in the driver code at the moment, but it could be used in BIOS as > > is the case with the Clevo laptop. > > > > The Clevo B7130 requires the CADL field to contain at least the ID of > > the LCD device. If this field is empty, the ACPI methods that are called > > on pressing brightness / display switching hotkeys will not trigger a > > notification. As a result, it appears as no hotkey has been pressed. > > Not ideal, but definitely better than nothing. > > Acked-by: Jesse Barnes Ok, 2nd try, I've merged this again to drm-intel-next. Let's hope it doesn't blow up again, now that the cpu edp fixes are merged. Thanks for the patch, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch