All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 2/5] ARM: bcm2835: add interrupt controller driver
Date: Fri, 14 Sep 2012 07:55:38 +0000	[thread overview]
Message-ID: <201209140755.38523.arnd@arndb.de> (raw)
In-Reply-To: <1347597684-30805-2-git-send-email-swarren@wwwdotorg.org>

On Friday 14 September 2012, Stephen Warren wrote:
> 
> From: Simon Arlott <simon@fire.lp0.eu>
> 
> The BCM2835 contains a custom interrupt controller, which supports 72
> interrupt sources using a 2-level register scheme. The interrupt
> controller, or the HW block containing it, is referred to occasionally
> as "armctrl" in the SoC documentation, hence the symbol naming in the
> code.
> 
> This patch was extracted from git://github.com/lp0/linux.git branch
> rpi-split as of 2012/09/08, and modified as follows:
> 
> * s/bcm2708/bcm2835/.
> * Modified device tree vendor prefix.
> * Moved implementation to drivers/irchip/.
> * Added devicetree documentation, and hence removed list of IRQs from
>   bcm2835.dtsi.
> * Changed shift in MAKE_HWIRQ() and HWIRQ_BANK() from 8 to 5 to reduce
>   the size of the hwirq space, and pass the total size of the hwirq space
>   to irq_domain_add_linear(), rather than just the number of valid hwirqs;
>   the two are different due to the hwirq space being sparse.
> * Added the interrupt controller DT node to the top-level of the DT,
>   rather than nesting it inside a /axi node. Hence, changed the reg value
>   since /axi had a ranges property. This seems simpler to me, but I'm not
>   sure if everyone will like this change or not.
> * Don't set struct irq_domain_ops.map = irq_domain_simple_map, hence
>   removing the need to patch include/linux/irqdomain.h or
>   kernel/irq/irqdomain.c.
> * Simplified armctrl_of_init() using of_iomap().
> * Removed unused IS_VALID_BANK()/IS_VALID_IRQ() macros.
> * Renamed armctrl_handle_irq() to prevent possible symbol clashes.
> * Made armctrl_of_init() static.
> * Removed comment "Each bank is registered as a separate interrupt
>   controller" since this is no longer true.
> * Removed FSF address from license header.
> * Added my name to copyright header.
> 
> Signed-off-by: Chris Boot <bootc@bootc.net>
> Signed-off-by: Simon Arlott <simon@fire.lp0.eu>
> Signed-off-by: Dom Cobley <popcornmix@gmail.com>
> Signed-off-by: Dom Cobley <dc4@broadcom.com>
> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>

Acked-by: Arnd Bergmann <arnd@arndb.de>

  reply	other threads:[~2012-09-14  7:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-14  4:41 [PATCH V4 1/5] ARM: add infra-structure for BCM2835 and Raspberry Pi Stephen Warren
2012-09-14  4:41 ` [PATCH V4 2/5] ARM: bcm2835: add interrupt controller driver Stephen Warren
2012-09-14  7:55   ` Arnd Bergmann [this message]
2012-09-14  4:41 ` [PATCH V4 3/5] ARM: bcm2835: add system timer Stephen Warren
2012-09-14  4:41 ` [PATCH V4 4/5] ARM: bcm2835: add stub clock driver Stephen Warren
2012-09-14  4:41 ` [PATCH V4 5/5] ARM: bcm2835: instantiate console UART Stephen Warren
2012-09-14  7:56   ` Arnd Bergmann
2012-09-14  7:50 ` [PATCH V4 1/5] ARM: add infra-structure for BCM2835 and Raspberry Pi Arnd Bergmann
2012-09-14 15:51   ` Stephen Warren
2012-09-14 20:01     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201209140755.38523.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.