All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] Staging: silicom: add some range checks to proc functions
Date: Fri, 14 Sep 2012 08:11:13 +0000	[thread overview]
Message-ID: <20120914081113.GD13767@mwanda> (raw)
In-Reply-To: <20120914065600.GF11886@elgon.mountain>

On Fri, Sep 14, 2012 at 10:08:30AM +0300, Dan Carpenter wrote:
> On Fri, Sep 14, 2012 at 09:56:00AM +0300, Dan Carpenter wrote:
> > If you tried to cat more than 255 characters (the last character is for
> > the terminator) to these proc files then it would corrupt kernel memory.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Actually sorry for this, I meant to check first before sending.  Is
> it possible to do a zero size write to a proc file?  In sysfs it
> isn't but I'm not sure about proc.
> 
> I may need to redo this.

I'm just busy having a conversation with myself.  This patch is
correct.  Please apply it after all.

regards,
dan carpenter


      parent reply	other threads:[~2012-09-14  8:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-14  6:56 [patch 1/2] Staging: silicom: add some range checks to proc functions Dan Carpenter
2012-09-14  7:08 ` Dan Carpenter
2012-09-14  8:11 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120914081113.GD13767@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.