From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 07/17] Documentation: Define the MSP Driver Device Tree bindings Date: Fri, 14 Sep 2012 10:57:02 +0100 Message-ID: <20120914095659.GQ3374@gmail.com> References: <1345816913-4113-1-git-send-email-lee.jones@linaro.org> <1345816913-4113-8-git-send-email-lee.jones@linaro.org> <20120910164333.GB24506@gmail.com> <504EFF86.10105@stericsson.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ey0-f179.google.com (mail-ey0-f179.google.com [209.85.215.179]) by alsa0.perex.cz (Postfix) with ESMTP id 8C2E5265CD2 for ; Fri, 14 Sep 2012 11:57:06 +0200 (CEST) Received: by eaa13 with SMTP id 13so1357741eaa.38 for ; Fri, 14 Sep 2012 02:57:06 -0700 (PDT) Content-Disposition: inline In-Reply-To: <504EFF86.10105@stericsson.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Ola Lilja Cc: "alsa-devel@alsa-project.org" , Linus WALLEIJ , "arnd@arndb.de" , Roger NILSSON1 , "broonie@opensource.wolfsonmicro.com" , "linux-kernel@vger.kernel.org" , STEricsson_nomadik_linux , "linux-arm-kernel@lists.infradead.org" List-Id: alsa-devel@alsa-project.org T24gVHVlLCBTZXAgMTEsIDIwMTIgYXQgMTE6MDg6MjJBTSArMDIwMCwgT2xhIExpbGphIHdyb3Rl Ogo+IE9uIDA5LzEwLzIwMTIgMDY6NDMgUE0sIExlZSBKb25lcyB3cm90ZToKPiAKPiA+IE9sYSBw b2tlLgo+ID4gCj4gPiBPbiBGcmksIEF1ZyAyNCwgMjAxMiBhdCAwMzowMTo0M1BNICswMTAwLCBM ZWUgSm9uZXMgd3JvdGU6Cj4gPj4gSGVyZSB3ZSBhZGQgdGhlIHJlcXVpcmVkIGRvY3VtZW50YXRp b24gZm9yIHRoZSBuZXcgRGV2aWNlIFRyZWUKPiA+PiBiaW5kaW5ncyBwZXJ0YWluaW5nIHRvIHRo ZSBNU1AgQ1BVLXNpZGUgREFJIERyaXZlci4KPiA+PiAKPiA+PiBDQzogYWxzYS1kZXZlbEBhbHNh LXByb2plY3Qub3JnCj4gPj4gU2lnbmVkLW9mZi1ieTogTGVlIEpvbmVzIDxsZWUuam9uZXNAbGlu YXJvLm9yZz4KPiA+PiAtLS0KPiA+PiAgLi4uL2RldmljZXRyZWUvYmluZGluZ3Mvc291bmQvdXg1 MDAtbXNwLnR4dCAgICAgICAgfCAgIDQzICsrKysrKysrKysrKysrKysrKysrCj4gPj4gIDEgZmls ZSBjaGFuZ2VkLCA0MyBpbnNlcnRpb25zKCspCj4gPj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvc291bmQvdXg1MDAtbXNwLnR4dAo+ID4+IAo+ ID4+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvc291bmQv dXg1MDAtbXNwLnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9zb3VuZC91 eDUwMC1tc3AudHh0Cj4gPj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiA+PiBpbmRleCAwMDAwMDAw Li45OWFjZDljCj4gPj4gLS0tIC9kZXYvbnVsbAo+ID4+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9zb3VuZC91eDUwMC1tc3AudHh0Cj4gPj4gQEAgLTAsMCArMSw0MyBA QAo+ID4+ICsqIHV4NTAwIE1TUCAoQ1BVLXNpZGUgRGlnaXRhbCBBdWRpbyBJbnRlcmZhY2UpCj4g Pj4gKwo+ID4+ICtSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+ID4+ICsgLSBjb21wYXRpYmxlICAgICAg IDoic3Rlcmljc3Nvbix1eDUwMC1tc3AtaTJzIgo+ID4+ICsgLSByZWcgICAgICAgICAgICAgIDog UGh5c2ljYWwgYmFzZSBhZGRyZXNzIGFuZCBsZW5ndGggb2YgdGhlIGRldmljZSdzIHJlZ2lzdGVy cy4KPiA+PiArCj4gPj4gK09wdGlvbmFsIHByb3BlcnRpZXM6Cj4gPj4gKyAtIGludGVycnVwdHMg ICAgICAgOiBUaGUgaW50ZXJydXB0IG91dHB1dCBmcm9tIHRoZSBkZXZpY2UuCj4gPj4gKyAtIGlu dGVycnVwdC1wYXJlbnQgOiBUaGUgcGFyZW50IGludGVycnVwdCBjb250cm9sbGVyLgo+ID4+ICsg LSA8bmFtZT4tc3VwcGx5ICAgIDogUGhhbmRsZSB0byB0aGUgcmVndWxhdG9yIDxuYW1lPiBzdXBw bHkKPiA+PiArCj4gPj4gK0V4YW1wbGU6Cj4gPj4gKwo+ID4+ICsJc291bmQgewo+ID4+ICsJCWNv bXBhdGlibGUgPSAic3Rlcmljc3NvbixzbmQtc29jLW1vcDUwMCI7Cj4gPj4gKwo+ID4+ICsJCXN0 ZXJpY3Nzb24scGxhdGZvcm0tcGNtLWRtYSA9IDwmcGNtPjsKPiA+PiArCQlzdGVyaWNzc29uLGNw dS1kYWkgPSA8Jm1zcDEgJm1zcDM+Owo+ID4+ICsJCXN0ZXJpY3Nzb24sYXVkaW8tY29kZWMgPSA8 JmNvZGVjPjsKPiA+PiArCX07Cj4gPj4gKwo+ID4+ICsJcGNtOiB1eDUwMC1wY20gewo+ID4+ICsJ CWNvbXBhdGlibGUgPSAic3Rlcmljc3Nvbix1eDUwMC1wY20iOwo+ID4+ICsJfTsKPiA+PiArCj4g Pj4gKwltc3AxOiBtc3BAODAxMjQwMDAgewo+ID4+ICsJCWNvbXBhdGlibGUgPSAic3Rlcmljc3Nv bix1eDUwMC1tc3AtaTJzIjsKPiA+PiArCQlyZWcgPSA8MHg4MDEyNDAwMCAweDEwMDA+Owo+ID4+ ICsJCWludGVycnVwdHMgPSA8MCA2MiAweDQ+Owo+ID4+ICsJCXYtYXBlLXN1cHBseSA9IDwmZGI4 NTAwX3ZhcGVfcmVnPjsKPiA+PiArCX07Cj4gPj4gKwo+ID4+ICsJbXNwMzogbXNwQDgwMTI1MDAw IHsKPiA+PiArCQljb21wYXRpYmxlID0gInN0ZXJpY3Nzb24sdXg1MDAtbXNwLWkycyI7Cj4gPj4g KwkJcmVnID0gPDB4ODAxMjUwMDAgMHgxMDAwPjsKPiA+PiArCQlpbnRlcnJ1cHRzID0gPDAgNjIg MHg0PjsKPiA+PiArCQl2LWFwZS1zdXBwbHkgPSA8JmRiODUwMF92YXBlX3JlZz47Cj4gPj4gKwl9 Owo+ID4+ICsKPiA+PiArCWNvZGVjOiBhYjg1MDAtY29kZWMgewo+ID4+ICsJCWNvbXBhdGlibGUg PSAic3Rlcmljc3NvbixhYjg1MDAtY29kZWMiOwo+ID4+ICsJCXN0ZXJpY3Nzb24sZWFycGVpY2Ut Y212ID0gPDk1MD47IC8qIFVuaXRzIGluIG1WLiAqLwo+IAo+IAo+IFRoaXMgcGFyYW1ldGVyIGhh cyBub3RoaW5nIHRvIGRvIHdpdGggdGhlIEFTb0MgcGxhdGZvcm0tZHJpdmVyLiBTb21lIHdheSBv ciB0aGUKPiBvdGhlciB0aGUgZWFycGllY2UtY212IHNob3VsZCBiZWxvbmcgdG8gdGhlIGNvZGVj LWRyaXZlci4gQWxzbywgdGhpcyBwYXJhbWV0ZXIKPiB3YXMgc2V0IGluIHRoZSBwcmV2aW91cyBw YXRjaCBhcyB3ZWxsPyEKCllvdSBrbm93IHRoYXQgdGhpcyBpcyBqdXN0IGEgZG9jdW1lbnRhdGlv biBwYXRjaCByaWdodD8KCkl0IGp1c3Qgc2hvd3MgaG93IHRoZSBwaWVjZXMgZml0IHRvZ2V0aGVy LiBObyBzZXR0aW5ncyB3aWxsIGFjdHVhbGx5CmJlIHJlYWQgZnJvbSBoZXJlLCBpdCdzIGp1c3Qg YSAudHh0IGZpbGUgdXNlZCBmb3IgcmVmZXJlbmNlLgoKS2luZCByZWdhcmRzLApMZWUKCi0tIApM ZWUgSm9uZXMKTGluYXJvIFNULUVyaWNzc29uIExhbmRpbmcgVGVhbSBMZWFkCkxpbmFyby5vcmcg 4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJvOiBGYWNl Ym9vayB8IFR3aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkFsc2EtZGV2ZWwgbWFpbGluZyBsaXN0CkFsc2EtZGV2ZWxAYWxzYS1wcm9q ZWN0Lm9yZwpodHRwOi8vbWFpbG1hbi5hbHNhLXByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8v YWxzYS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Fri, 14 Sep 2012 10:57:02 +0100 Subject: [PATCH 07/17] Documentation: Define the MSP Driver Device Tree bindings In-Reply-To: <504EFF86.10105@stericsson.com> References: <1345816913-4113-1-git-send-email-lee.jones@linaro.org> <1345816913-4113-8-git-send-email-lee.jones@linaro.org> <20120910164333.GB24506@gmail.com> <504EFF86.10105@stericsson.com> Message-ID: <20120914095659.GQ3374@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Sep 11, 2012 at 11:08:22AM +0200, Ola Lilja wrote: > On 09/10/2012 06:43 PM, Lee Jones wrote: > > > Ola poke. > > > > On Fri, Aug 24, 2012 at 03:01:43PM +0100, Lee Jones wrote: > >> Here we add the required documentation for the new Device Tree > >> bindings pertaining to the MSP CPU-side DAI Driver. > >> > >> CC: alsa-devel at alsa-project.org > >> Signed-off-by: Lee Jones > >> --- > >> .../devicetree/bindings/sound/ux500-msp.txt | 43 ++++++++++++++++++++ > >> 1 file changed, 43 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/sound/ux500-msp.txt > >> > >> diff --git a/Documentation/devicetree/bindings/sound/ux500-msp.txt b/Documentation/devicetree/bindings/sound/ux500-msp.txt > >> new file mode 100644 > >> index 0000000..99acd9c > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/sound/ux500-msp.txt > >> @@ -0,0 +1,43 @@ > >> +* ux500 MSP (CPU-side Digital Audio Interface) > >> + > >> +Required properties: > >> + - compatible :"stericsson,ux500-msp-i2s" > >> + - reg : Physical base address and length of the device's registers. > >> + > >> +Optional properties: > >> + - interrupts : The interrupt output from the device. > >> + - interrupt-parent : The parent interrupt controller. > >> + - -supply : Phandle to the regulator supply > >> + > >> +Example: > >> + > >> + sound { > >> + compatible = "stericsson,snd-soc-mop500"; > >> + > >> + stericsson,platform-pcm-dma = <&pcm>; > >> + stericsson,cpu-dai = <&msp1 &msp3>; > >> + stericsson,audio-codec = <&codec>; > >> + }; > >> + > >> + pcm: ux500-pcm { > >> + compatible = "stericsson,ux500-pcm"; > >> + }; > >> + > >> + msp1: msp at 80124000 { > >> + compatible = "stericsson,ux500-msp-i2s"; > >> + reg = <0x80124000 0x1000>; > >> + interrupts = <0 62 0x4>; > >> + v-ape-supply = <&db8500_vape_reg>; > >> + }; > >> + > >> + msp3: msp at 80125000 { > >> + compatible = "stericsson,ux500-msp-i2s"; > >> + reg = <0x80125000 0x1000>; > >> + interrupts = <0 62 0x4>; > >> + v-ape-supply = <&db8500_vape_reg>; > >> + }; > >> + > >> + codec: ab8500-codec { > >> + compatible = "stericsson,ab8500-codec"; > >> + stericsson,earpeice-cmv = <950>; /* Units in mV. */ > > > This parameter has nothing to do with the ASoC platform-driver. Some way or the > other the earpiece-cmv should belong to the codec-driver. Also, this parameter > was set in the previous patch as well?! You know that this is just a documentation patch right? It just shows how the pieces fit together. No settings will actually be read from here, it's just a .txt file used for reference. Kind regards, Lee -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755930Ab2INJ5O (ORCPT ); Fri, 14 Sep 2012 05:57:14 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:64203 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755002Ab2INJ5I (ORCPT ); Fri, 14 Sep 2012 05:57:08 -0400 Date: Fri, 14 Sep 2012 10:57:02 +0100 From: Lee Jones To: Ola Lilja Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , STEricsson_nomadik_linux , Linus WALLEIJ , "arnd@arndb.de" , "broonie@opensource.wolfsonmicro.com" , Roger NILSSON1 , "alsa-devel@alsa-project.org" Subject: Re: [PATCH 07/17] Documentation: Define the MSP Driver Device Tree bindings Message-ID: <20120914095659.GQ3374@gmail.com> References: <1345816913-4113-1-git-send-email-lee.jones@linaro.org> <1345816913-4113-8-git-send-email-lee.jones@linaro.org> <20120910164333.GB24506@gmail.com> <504EFF86.10105@stericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <504EFF86.10105@stericsson.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 11, 2012 at 11:08:22AM +0200, Ola Lilja wrote: > On 09/10/2012 06:43 PM, Lee Jones wrote: > > > Ola poke. > > > > On Fri, Aug 24, 2012 at 03:01:43PM +0100, Lee Jones wrote: > >> Here we add the required documentation for the new Device Tree > >> bindings pertaining to the MSP CPU-side DAI Driver. > >> > >> CC: alsa-devel@alsa-project.org > >> Signed-off-by: Lee Jones > >> --- > >> .../devicetree/bindings/sound/ux500-msp.txt | 43 ++++++++++++++++++++ > >> 1 file changed, 43 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/sound/ux500-msp.txt > >> > >> diff --git a/Documentation/devicetree/bindings/sound/ux500-msp.txt b/Documentation/devicetree/bindings/sound/ux500-msp.txt > >> new file mode 100644 > >> index 0000000..99acd9c > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/sound/ux500-msp.txt > >> @@ -0,0 +1,43 @@ > >> +* ux500 MSP (CPU-side Digital Audio Interface) > >> + > >> +Required properties: > >> + - compatible :"stericsson,ux500-msp-i2s" > >> + - reg : Physical base address and length of the device's registers. > >> + > >> +Optional properties: > >> + - interrupts : The interrupt output from the device. > >> + - interrupt-parent : The parent interrupt controller. > >> + - -supply : Phandle to the regulator supply > >> + > >> +Example: > >> + > >> + sound { > >> + compatible = "stericsson,snd-soc-mop500"; > >> + > >> + stericsson,platform-pcm-dma = <&pcm>; > >> + stericsson,cpu-dai = <&msp1 &msp3>; > >> + stericsson,audio-codec = <&codec>; > >> + }; > >> + > >> + pcm: ux500-pcm { > >> + compatible = "stericsson,ux500-pcm"; > >> + }; > >> + > >> + msp1: msp@80124000 { > >> + compatible = "stericsson,ux500-msp-i2s"; > >> + reg = <0x80124000 0x1000>; > >> + interrupts = <0 62 0x4>; > >> + v-ape-supply = <&db8500_vape_reg>; > >> + }; > >> + > >> + msp3: msp@80125000 { > >> + compatible = "stericsson,ux500-msp-i2s"; > >> + reg = <0x80125000 0x1000>; > >> + interrupts = <0 62 0x4>; > >> + v-ape-supply = <&db8500_vape_reg>; > >> + }; > >> + > >> + codec: ab8500-codec { > >> + compatible = "stericsson,ab8500-codec"; > >> + stericsson,earpeice-cmv = <950>; /* Units in mV. */ > > > This parameter has nothing to do with the ASoC platform-driver. Some way or the > other the earpiece-cmv should belong to the codec-driver. Also, this parameter > was set in the previous patch as well?! You know that this is just a documentation patch right? It just shows how the pieces fit together. No settings will actually be read from here, it's just a .txt file used for reference. Kind regards, Lee -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog