From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 06/17] Documentation: Define the MOP500 Audio Machine Driver Device Tree bindings Date: Fri, 14 Sep 2012 11:02:57 +0100 Message-ID: <20120914100254.GR3374@gmail.com> References: <1345816913-4113-1-git-send-email-lee.jones@linaro.org> <1345816913-4113-7-git-send-email-lee.jones@linaro.org> <20120910164413.GC24506@gmail.com> <504EFEF8.6020707@stericsson.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51]) by alsa0.perex.cz (Postfix) with ESMTP id 2345D265CF8 for ; Fri, 14 Sep 2012 12:03:01 +0200 (CEST) Received: by eeke50 with SMTP id e50so2058261eek.38 for ; Fri, 14 Sep 2012 03:03:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <504EFEF8.6020707@stericsson.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Ola Lilja Cc: "alsa-devel@alsa-project.org" , Linus WALLEIJ , "arnd@arndb.de" , Roger NILSSON1 , "broonie@opensource.wolfsonmicro.com" , "linux-kernel@vger.kernel.org" , STEricsson_nomadik_linux , "linux-arm-kernel@lists.infradead.org" List-Id: alsa-devel@alsa-project.org T24gVHVlLCBTZXAgMTEsIDIwMTIgYXQgMTE6MDY6MDBBTSArMDIwMCwgT2xhIExpbGphIHdyb3Rl Ogo+IE9uIDA5LzEwLzIwMTIgMDY6NDQgUE0sIExlZSBKb25lcyB3cm90ZToKPiAKPiA+IE9sYSBw b2tlLgo+ID4gCj4gPiBPbiBGcmksIEF1ZyAyNCwgMjAxMiBhdCAwMzowMTo0MlBNICswMTAwLCBM ZWUgSm9uZXMgd3JvdGU6Cj4gPj4gSGVyZSB3ZSBhZGQgdGhlIHJlcXVpcmVkIGRvY3VtZW50YXRp b24gZm9yIHRoZSBuZXcgRGV2aWNlIFRyZWUKPiA+PiBiaW5kaW5ncyBwZXJ0YWluaW5nIHRvIHRo ZSBNT1A1MDAgQXVkaW8gTWFjaGluZSBkcml2ZXIuCj4gPj4gCj4gPj4gQ0M6IGFsc2EtZGV2ZWxA YWxzYS1wcm9qZWN0Lm9yZwo+ID4+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVz QGxpbmFyby5vcmc+Cj4gPj4gLS0tCj4gPj4gIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NvdW5k L3V4NTAwLW1vcDUwMC50eHQgICAgIHwgICAzOSArKysrKysrKysrKysrKysrKysrKwo+ID4+ICAx IGZpbGUgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKQo+ID4+ICBjcmVhdGUgbW9kZSAxMDA2NDQg RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NvdW5kL3V4NTAwLW1vcDUwMC50eHQK PiA+PiAKPiA+PiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L3NvdW5kL3V4NTAwLW1vcDUwMC50eHQgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3Mvc291bmQvdXg1MDAtbW9wNTAwLnR4dAo+ID4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gPj4g aW5kZXggMDAwMDAwMC4uNDhlMDcxYwo+ID4+IC0tLSAvZGV2L251bGwKPiA+PiArKysgYi9Eb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mvc291bmQvdXg1MDAtbW9wNTAwLnR4dAo+ID4+ IEBAIC0wLDAgKzEsMzkgQEAKPiA+PiArKiBNT1A1MDAgQXVkaW8gTWFjaGluZSBEcml2ZXIKPiA+ PiArCj4gPj4gK1RoaXMgbm9kZSBpcyByZXNwb25zaWJsZSBmb3IgbGlua2luZyB0b2dldGhlciBh bGwgdXg1MDAgQXVkaW8gRHJpdmVyIGNvbXBvbmVudHMuCj4gPj4gKwo+ID4+ICtSZXF1aXJlZCBw cm9wZXJ0aWVzOgo+ID4+ICsgLSBjb21wYXRpYmxlICAgICAgICAgICAgICA6ICJzdGVyaWNzc29u LHNuZC1zb2MtbW9wNTAwIgo+ID4+ICsKPiA+PiArTm9uLXN0YW5kYXJkIHByb3BlcnRpZXM6Cj4g Pj4gKyAtIHN0ZXJpY3Nzb24sY3B1LWRhaSAgICAgIDogUGhhbmRsZSB0byB0aGUgQ1BVLXNpZGUg REFJCj4gPj4gKyAtIHN0ZXJpY3Nzb24sYXVkaW8tY29kZWMgIDogUGhhbmRsZSB0byB0aGUgQXVk aW8gQ09ERUMKPiA+PiArIC0gc3Rlcmljc3NvbixjYXJkLW5hbWUgICAgOiBPdmVyLXJpZGUgZGVm YXVsdCBjYXJkIG5hbWUKPiA+PiArCj4gPj4gK0V4YW1wbGU6Cj4gPj4gKwo+ID4+ICsJc291bmQg ewo+ID4+ICsJCWNvbXBhdGlibGUgPSAic3Rlcmljc3NvbixzbmQtc29jLW1vcDUwMCI7Cj4gPj4g Kwo+ID4+ICsJCXN0ZXJpY3Nzb24sY3B1LWRhaSA9IDwmbXNwMSAmbXNwMz47Cj4gPj4gKwkJc3Rl cmljc3NvbixhdWRpby1jb2RlYyA9IDwmY29kZWM+Owo+ID4+ICsJfTsKPiA+PiArCj4gPj4gKwlt c3AxOiBtc3BAODAxMjQwMDAgewo+ID4+ICsJCWNvbXBhdGlibGUgPSAic3Rlcmljc3Nvbix1eDUw MC1tc3AtaTJzIjsKPiA+PiArCQlyZWcgPSA8MHg4MDEyNDAwMCAweDEwMDA+Owo+ID4+ICsJCWlu dGVycnVwdHMgPSA8MCA2MiAweDQ+Owo+ID4+ICsJCXYtYXBlLXN1cHBseSA9IDwmZGI4NTAwX3Zh cGVfcmVnPjsKPiAKPiAKPiBJJ20gbm8gRFQtZXhwZXJ0LCBidXQgd2h5IGFyZSB5b3UgYWRkaW5n IE1TUC1zdHVmZiBpbiB0aGUgbWFjaGluZS1kcml2ZXI/IFRoZXkKPiBhcmUgYWxzbyBhZGRlZCBp biB0aGUgbmV4dCBwYXRjaC4KClRoaXMgaXMgYSBkb2N1bWVudGF0aW9uIGZpbGUuIER1cGxpY2F0 aW9uIGlzIG5vdCBpbXBvcnRhbnQsIGFzIGl0J3Mgb25seSB0aGVyZQpmb3IgcmVmZXJlbmNlLgoK PiA+PiArCX07Cj4gPj4gKwo+ID4+ICsJbXNwMzogbXNwQDgwMTI1MDAwIHsKPiA+PiArCQljb21w YXRpYmxlID0gInN0ZXJpY3Nzb24sdXg1MDAtbXNwLWkycyI7Cj4gPj4gKwkJcmVnID0gPDB4ODAx MjUwMDAgMHgxMDAwPjsKPiA+PiArCQlpbnRlcnJ1cHRzID0gPDAgNjIgMHg0PjsKPiA+PiArCQl2 LWFwZS1zdXBwbHkgPSA8JmRiODUwMF92YXBlX3JlZz47Cj4gPj4gKwl9Owo+ID4+ICsKPiA+PiAr CWNvZGVjOiBhYjg1MDAtY29kZWMgewo+ID4+ICsJCWNvbXBhdGlibGUgPSAic3Rlcmljc3Nvbixh Yjg1MDAtY29kZWMiOwo+ID4+ICsJCXN0ZXJpY3Nzb24sZWFycGVpY2UtY212ID0gPDk1MD47IC8q IFVuaXRzIGluIG1WLiAqLwo+IAo+IAo+IE9ubHkgZm91ciB2b2x0YWdlcyBhcmUgYWxsb3dlZCBo ZXJlLiBNYXliZSBlbnVtZXJhdGUgdGhlbSBpbiB0aGUgY29tbWVudD8KClRoaXMgaXNuJ3QgdGhl IGFiODUwMC1jb2RlYyBkb2N1bWVudGF0aW9uLiBGb3IgdmFsaWQgZWFycGllY2UgdmFsdWVzIHBs ZWFzZQpzZWUgdGhlIGRvY3VtZW50YXRpb24gaW4gcGF0Y2ggIkRvY3VtZW50YXRpb246IEFkZCB0 aGUgQUI4NTAwIENPREVDIGRldmljZQp0byB0aGUgTUZEIEFCODUwMCBkb2MiCgpBcGFydCBmcm9t IHRoZXNlIGNvbW1lbnRzIGRvZXMgdGhlIHBhdGNoIGxvb2tzIG9rYXk/CgotLSAKTGVlIEpvbmVz CkxpbmFybyBTVC1Fcmljc3NvbiBMYW5kaW5nIFRlYW0gTGVhZApMaW5hcm8ub3JnIOKUgiBPcGVu IHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzogRmFjZWJvb2sgfCBU d2l0dGVyIHwgQmxvZwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpBbHNhLWRldmVsIG1haWxpbmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcK aHR0cDovL21haWxtYW4uYWxzYS1wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2 ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Fri, 14 Sep 2012 11:02:57 +0100 Subject: [PATCH 06/17] Documentation: Define the MOP500 Audio Machine Driver Device Tree bindings In-Reply-To: <504EFEF8.6020707@stericsson.com> References: <1345816913-4113-1-git-send-email-lee.jones@linaro.org> <1345816913-4113-7-git-send-email-lee.jones@linaro.org> <20120910164413.GC24506@gmail.com> <504EFEF8.6020707@stericsson.com> Message-ID: <20120914100254.GR3374@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Sep 11, 2012 at 11:06:00AM +0200, Ola Lilja wrote: > On 09/10/2012 06:44 PM, Lee Jones wrote: > > > Ola poke. > > > > On Fri, Aug 24, 2012 at 03:01:42PM +0100, Lee Jones wrote: > >> Here we add the required documentation for the new Device Tree > >> bindings pertaining to the MOP500 Audio Machine driver. > >> > >> CC: alsa-devel at alsa-project.org > >> Signed-off-by: Lee Jones > >> --- > >> .../devicetree/bindings/sound/ux500-mop500.txt | 39 ++++++++++++++++++++ > >> 1 file changed, 39 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/sound/ux500-mop500.txt > >> > >> diff --git a/Documentation/devicetree/bindings/sound/ux500-mop500.txt b/Documentation/devicetree/bindings/sound/ux500-mop500.txt > >> new file mode 100644 > >> index 0000000..48e071c > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/sound/ux500-mop500.txt > >> @@ -0,0 +1,39 @@ > >> +* MOP500 Audio Machine Driver > >> + > >> +This node is responsible for linking together all ux500 Audio Driver components. > >> + > >> +Required properties: > >> + - compatible : "stericsson,snd-soc-mop500" > >> + > >> +Non-standard properties: > >> + - stericsson,cpu-dai : Phandle to the CPU-side DAI > >> + - stericsson,audio-codec : Phandle to the Audio CODEC > >> + - stericsson,card-name : Over-ride default card name > >> + > >> +Example: > >> + > >> + sound { > >> + compatible = "stericsson,snd-soc-mop500"; > >> + > >> + stericsson,cpu-dai = <&msp1 &msp3>; > >> + stericsson,audio-codec = <&codec>; > >> + }; > >> + > >> + msp1: msp at 80124000 { > >> + compatible = "stericsson,ux500-msp-i2s"; > >> + reg = <0x80124000 0x1000>; > >> + interrupts = <0 62 0x4>; > >> + v-ape-supply = <&db8500_vape_reg>; > > > I'm no DT-expert, but why are you adding MSP-stuff in the machine-driver? They > are also added in the next patch. This is a documentation file. Duplication is not important, as it's only there for reference. > >> + }; > >> + > >> + msp3: msp at 80125000 { > >> + compatible = "stericsson,ux500-msp-i2s"; > >> + reg = <0x80125000 0x1000>; > >> + interrupts = <0 62 0x4>; > >> + v-ape-supply = <&db8500_vape_reg>; > >> + }; > >> + > >> + codec: ab8500-codec { > >> + compatible = "stericsson,ab8500-codec"; > >> + stericsson,earpeice-cmv = <950>; /* Units in mV. */ > > > Only four voltages are allowed here. Maybe enumerate them in the comment? This isn't the ab8500-codec documentation. For valid earpiece values please see the documentation in patch "Documentation: Add the AB8500 CODEC device to the MFD AB8500 doc" Apart from these comments does the patch looks okay? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758195Ab2INKDF (ORCPT ); Fri, 14 Sep 2012 06:03:05 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:37321 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755566Ab2INKDC (ORCPT ); Fri, 14 Sep 2012 06:03:02 -0400 Date: Fri, 14 Sep 2012 11:02:57 +0100 From: Lee Jones To: Ola Lilja Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , STEricsson_nomadik_linux , Linus WALLEIJ , "arnd@arndb.de" , "broonie@opensource.wolfsonmicro.com" , Roger NILSSON1 , "alsa-devel@alsa-project.org" Subject: Re: [PATCH 06/17] Documentation: Define the MOP500 Audio Machine Driver Device Tree bindings Message-ID: <20120914100254.GR3374@gmail.com> References: <1345816913-4113-1-git-send-email-lee.jones@linaro.org> <1345816913-4113-7-git-send-email-lee.jones@linaro.org> <20120910164413.GC24506@gmail.com> <504EFEF8.6020707@stericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <504EFEF8.6020707@stericsson.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 11, 2012 at 11:06:00AM +0200, Ola Lilja wrote: > On 09/10/2012 06:44 PM, Lee Jones wrote: > > > Ola poke. > > > > On Fri, Aug 24, 2012 at 03:01:42PM +0100, Lee Jones wrote: > >> Here we add the required documentation for the new Device Tree > >> bindings pertaining to the MOP500 Audio Machine driver. > >> > >> CC: alsa-devel@alsa-project.org > >> Signed-off-by: Lee Jones > >> --- > >> .../devicetree/bindings/sound/ux500-mop500.txt | 39 ++++++++++++++++++++ > >> 1 file changed, 39 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/sound/ux500-mop500.txt > >> > >> diff --git a/Documentation/devicetree/bindings/sound/ux500-mop500.txt b/Documentation/devicetree/bindings/sound/ux500-mop500.txt > >> new file mode 100644 > >> index 0000000..48e071c > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/sound/ux500-mop500.txt > >> @@ -0,0 +1,39 @@ > >> +* MOP500 Audio Machine Driver > >> + > >> +This node is responsible for linking together all ux500 Audio Driver components. > >> + > >> +Required properties: > >> + - compatible : "stericsson,snd-soc-mop500" > >> + > >> +Non-standard properties: > >> + - stericsson,cpu-dai : Phandle to the CPU-side DAI > >> + - stericsson,audio-codec : Phandle to the Audio CODEC > >> + - stericsson,card-name : Over-ride default card name > >> + > >> +Example: > >> + > >> + sound { > >> + compatible = "stericsson,snd-soc-mop500"; > >> + > >> + stericsson,cpu-dai = <&msp1 &msp3>; > >> + stericsson,audio-codec = <&codec>; > >> + }; > >> + > >> + msp1: msp@80124000 { > >> + compatible = "stericsson,ux500-msp-i2s"; > >> + reg = <0x80124000 0x1000>; > >> + interrupts = <0 62 0x4>; > >> + v-ape-supply = <&db8500_vape_reg>; > > > I'm no DT-expert, but why are you adding MSP-stuff in the machine-driver? They > are also added in the next patch. This is a documentation file. Duplication is not important, as it's only there for reference. > >> + }; > >> + > >> + msp3: msp@80125000 { > >> + compatible = "stericsson,ux500-msp-i2s"; > >> + reg = <0x80125000 0x1000>; > >> + interrupts = <0 62 0x4>; > >> + v-ape-supply = <&db8500_vape_reg>; > >> + }; > >> + > >> + codec: ab8500-codec { > >> + compatible = "stericsson,ab8500-codec"; > >> + stericsson,earpeice-cmv = <950>; /* Units in mV. */ > > > Only four voltages are allowed here. Maybe enumerate them in the comment? This isn't the ab8500-codec documentation. For valid earpiece values please see the documentation in patch "Documentation: Add the AB8500 CODEC device to the MFD AB8500 doc" Apart from these comments does the patch looks okay? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog