From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============3739502325578549869==" MIME-Version: 1.0 From: Sergey Senozhatsky Subject: Re: [Powertop] [PATCH] Remove unneded escaping backslashes from CSS Date: Fri, 14 Sep 2012 13:29:40 +0300 Message-ID: <20120914102940.GC3053@swordfish.minsk.epam.com> In-Reply-To: 505303C5.8090902@samsung.com To: powertop@lists.01.org List-ID: --===============3739502325578549869== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On (09/14/12 14:15), Igor Zhbanov wrote: > Dear Paul, > = > Paul Menzel wrote: > >Am Freitag, den 14.09.2012, 13:46 +0400 schrieb Igor Zhbanov: > >>Remove unneded escaping backslashes from CSS. > >copying the summary into the body is not useful, because it adds no > >further information. > What to do when the commit summary describes all of the issue? > Should I left body empty? > >Please also add why the escaping was added beforehand and why it is > >unneeded. > I don't know why this particular escapes was added. > In the file powertop.css there are lots of escaped quotes characters (") > because later each line of this file will be wrapped inside of "LINE\n" > to form a C array css[] in the file css.h. > = > But I don't know the reason for putting backslashes before slash in a > closing > tag for jQuery append() method. I don't know any special handling > of slashes in append() method. > = > Should I repost the patch with another description? > personally, I don't think so. it's rather hard to come up with commit messa= ge when commit summary tells the whole story. = -ss > >>--- > >> src/powertop.css | 16 ++++++++-------- > >> 1 files changed, 8 insertions(+), 8 deletions(-) > >> > >>diff --git a/src/powertop.css b/src/powertop.css > >>index 087e384..5d303dc 100644 > >>--- a/src/powertop.css > >>+++ b/src/powertop.css > >>@@ -21,14 +21,14 @@ $(document).ready(function(){ > >> $('#tuning h2').addClass('hide'); > >> $('#tuning table').addClass('hide'); > >>- $('#top').append('
System Info<\\/div>'); > >>- $('#top').append('
Summary<\\/div>'); > >>- $('#top').append('
CPU Idle<\\/div>'); > >>- $('#top').append('
CPU Frequency<\\/div>'); > >>- $('#top').append('
Software info<\\/div>'); > >>- $('#top').append('
Device Info<\\/div>'); > >>- $('#top').append('
Tuning<\\/div>'); > >>- $('#top').append('
All<\\/div>'); > >>+ $('#top').append('
System Info
'); > >>+ $('#top').append('
Summary
'); > >>+ $('#top').append('
CPU Idle
'); > >>+ $('#top').append('
CPU Frequency
'); > >>+ $('#top').append('
Software info
'); > >>+ $('#top').append('
Device Info
'); > >>+ $('#top').append('
Tuning
'); > >>+ $('#top').append('
All
'); > >> $('#top .SummaryButton').toggleClass('pressed'); > >> } > = > -- = > Best regards, > Igor Zhbanov, > Expert Software Engineer, > phone: +7 (495) 797 25 00 ext 3806 > e-mail: i.zhbanov(a)samsung.com > = > ASWG, Moscow R&D center, Samsung Electronics > 12 Dvintsev street, building 1 > 127018, Moscow, Russian Federation > = > _______________________________________________ > PowerTop mailing list > PowerTop(a)lists.01.org > https://lists.01.org/mailman/listinfo/powertop >=20 --===============3739502325578549869==--